Bug 361231 - Review Request: rubygem-actionmailer - Service layer for easy email delivery and testing
Summary: Review Request: rubygem-actionmailer - Service layer for easy email delivery ...
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
Target Milestone: ---
Assignee: Scott Seago
QA Contact: Fedora Extras Quality Assurance
Depends On:
Blocks: 361191
TreeView+ depends on / blocked
Reported: 2007-11-01 01:53 UTC by David Lutterkort
Modified: 2013-04-30 23:40 UTC (History)
3 users (show)

Clone Of:
Last Closed: 2007-12-03 23:49:57 UTC
sseago: fedora-review+
kevin: fedora-cvs+

Attachments (Terms of Use)

Description David Lutterkort 2007-11-01 01:53:13 UTC
Spec URL: http://people.redhat.com/dlutter/yum/spec/rubygem-actionmailer.spec
SRPM URL: http://people.redhat.com/dlutter/yum/SRPMS/rubygem-actionmailer-1.3.5-1.src.rpm


Makes it trivial to test and deliver emails sent from a single service layer.

Comment 1 Scott Seago 2007-11-07 16:55:00 UTC
OK - Package name
OK - License info is accurate
OK - License tag is correct and licenses are approved
OK - Specfile name
OK - Specfile is legible
OK - No prebuilt binaries included
OK - PreReq not used
OK - Source md5sum matches upstream
OK - No hardcoded pathnames
OK - Package owns all the files it installs
OK - Package requires create needed unowned directories
OK - Package builds successfully on i386 and x86_64 
OK - BuildRequires sufficient
OK - File permissions set properly (except for rpmlint error below)
OK - Macro usage is consistent

OK - Package is named rubygem-%{gemname}
OK - Source points to full URL of gem
OK - Package version identical with gem version
OK - Package Requires and BuildRequires rubygems
OK - Package provides rubygem(%{gemname}) = %version
OK - Package requires gem dependencies correctly
OK - %prep and %build are empty
OK - %gemdir defined properly, and gem installed into it
OK - Package owns its directories under %gemdir
OK - No arch-specific content in %{gemdir}
OK - Package is noarch

??? - BuildRoot value: not sure if this is really a problem, but it
  looks like %{release} is omitted:

  BuildRoot: %{_tmppath}/%{name}-%{version}-root-%(%{__id_u} -n)
             %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)

FIX - MIT-LICENSE, README, CHANGELOG not installed as %doc
  general doc question: docs are included as regular gem
  files in %{geminstdir}, but not in %{_docdir}/%{name}-%{version} as
  in some of the packages Is there a clear preference for doc location?

FIX - rpmlint complains 
E: rubygem-actionmailer zero-length

Comment 2 David Lutterkort 2007-11-14 04:22:41 UTC
Fixed: buildroot
Fixed: marked various things in geminstdir as %doc

I left the zero-length file in there to minimize differences between the gem and
the rpm

Spec URL: http://people.redhat.com/dlutter/yum/spec/rubygem-actionmailer.spec

Comment 3 Scott Seago 2007-11-14 22:00:46 UTC

Comment 4 David Lutterkort 2007-11-28 19:20:01 UTC
New Package CVS Request
Package Name: rubygem-actionmailer
Short Description: Service layer for easy email delivery and testing
Owners: lutter,sseago
Branches: F-7 F-8
Cvsextras Commits: yes

Comment 5 Kevin Fenzi 2007-11-28 23:24:11 UTC
cvs done.

Comment 6 David Lutterkort 2007-12-03 23:49:57 UTC
Successfully imported and built.

Note You need to log in before you can comment on or make changes to this bug.