Spec URL: http://people.redhat.com/dlutter/yum/spec/rubygem-activerecord.spec SRPM URL: http://people.redhat.com/dlutter/yum/SRPMS/rubygem-activerecord-1.15.5-1.src.rpm Description: Implements the ActiveRecord pattern (Fowler, PoEAA) for ORM. It ties database tables and classes together for business objects, like Customer or Subscription, that can find, save, and destroy themselves without resorting to manual SQL.
OK - Package name OK - License info is accurate OK - License tag is correct and licenses are approved OK - Specfile name OK - Specfile is legible OK - No prebuilt binaries included OK - PreReq not used OK - Source md5sum matches upstream OK - No hardcoded pathnames OK - Package owns all the files it installs OK - Package requires create needed unowned directories OK - Package builds successfully on i386 and x86_64 OK - BuildRequires sufficient OK - File permissions set properly (except for rpmlint error below) OK - Macro usage is consistent OK - Package is named rubygem-%{gemname} OK - Source points to full URL of gem OK - Package version identical with gem version OK - Package Requires and BuildRequires rubygems OK - Package provides rubygem(%{gemname}) = %version OK - Package requires gem dependencies correctly OK - %prep and %build are empty OK - %gemdir defined properly, and gem installed into it OK - Package owns its directories under %gemdir OK - No arch-specific content in %{gemdir} OK - Package is noarch ??? - BuildRoot value: not sure if this is really a problem, but it looks like %{release} is omitted: BuildRoot: %{_tmppath}/%{name}-%{version}-root-%(%{__id_u} -n) vs. %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) FIX - CHANGELOG, RUNNING_UNIT_TESTS not installed as %doc general doc question: docs are included as regular gem files in %{geminstdir}, but not in %{_docdir}/%{name}-%{version} as in some of the packages Is there a clear preference for doc location? FIX - rpmlint complains E: rubygem-activerecord non-executable-script /usr/lib/ruby/gems/1.8/gems/activerecord-1.15.5/test/all.sh 0644
Fixed: buildroot Fixed: marked things in geminstdir properly as %doc Haven't fixed the complaint about the test script - since it's a test script I don't want to force it to 644 for security reasons, but would prefer not to edit out the #! to reduce divergence from upstream. Spec URL: http://people.redhat.com/dlutter/yum/spec/rubygem-activerecord.spec SRPM URL: http://people.redhat.com/dlutter/yum/SRPMS/rubygem-activerecord-1.15.5-2.src.rpm
Approved
New Package CVS Request ======================= Package Name: rubygem-activerecord Short Description: Implements the ActiveRecord pattern for ORM Owners: lutter,sseago Branches: F-7 F-8 InitialCC: Cvsextras Commits: yes
cvs done.
Successfully imported and built.