Bug 3619 - xdm doesn't copy environment variables from PAM to user session
xdm doesn't copy environment variables from PAM to user session
Status: CLOSED ERRATA
Product: Red Hat Linux
Classification: Retired
Component: XFree86 (Show other bugs)
6.0
All Linux
low Severity medium
: ---
: ---
Assigned To: Preston Brown
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 1999-06-21 13:21 EDT by Nalin Dahyabhai
Modified: 2008-05-01 11:37 EDT (History)
1 user (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 1999-08-31 14:48:13 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---


Attachments (Terms of Use)

  None (edit)
Description Nalin Dahyabhai 1999-06-21 13:21:26 EDT
If a module for PAM sets an environment variable (example:
a Kerberos module that needs to set the KRB5CCNAME or
KRBTKFILE variables to the names of ticket files for the
user), it doesn't get passed on to the user session that
gets started.  The fix (to session.c) might look something
like this:

#ifdef HAVE_PAM_MISC
    /* if we have a pam_misc library on this system, pass in
       environment variables set by libpam and modules it
       called */
    if(pamh != NULL)
    {
        long i;
        char **pam_env = pam_misc_copy_env(pamh);
        for(i = 0; pam_env && pam_env[i]; i++)
        {
            verify->userEnviron = putEnv(pam_env[i],
                                  verify->userEnviron);
        }
    }
#endif /* HAVE_PAM_MISC */

* kdm and gdm also have this problem.
Comment 1 Michael K. Johnson 1999-07-13 13:27:59 EDT
This code looks right at first glance.  It should be placed
directly after the section that calls pam_open_session().

We would also have to make sure that each of these components
links against -lpam_misc as well as -lpam, as well as define
HAVE_PAM_MISC.
Comment 2 Nalin Dahyabhai 1999-07-13 13:42:59 EDT
Actually, the code should just call pam_getenvlist() from libpam
instead of pam_misc_copy_env(), which is deprecated.  I missed it
because this is only documented in the pam_misc header file.
Mark has already fixed it in gdm2 in CVS.
Comment 3 Preston Brown 1999-08-31 14:48:59 EDT
fixed in our forthcoming XFree86 3.3.5 errata release.

Note You need to log in before you can comment on or make changes to this bug.