Spec URL: http://liviopl.jogger.pl/files/gnome-applet-tvn24.spec SRPM URL: http://liviopl.jogger.pl/files/gnome-applet-tvn24-0.2.8-1.fc7.src.rpm Description: Scrolled RSS aggregator for the polish TVN24 channel
Fails to build on x86_64: error: Installed (but unpackaged) file(s) found: /usr/lib/bonobo/servers/TVN24.server /usr/lib/tvn24/tvn24 /usr/lib/tvn24/tvn24.png RPM build errors: user livio does not exist - using root group livio does not exist - using root user livio does not exist - using root group livio does not exist - using root user livio does not exist - using root group livio does not exist - using root File not found: /var/tmp/gnome-applet-tvn24-0.2.8-1.fc7-root-build/usr/ lib64/tvn24 File not found: /var/tmp/gnome-applet-tvn24-0.2.8-1.fc7-root-build/usr/ lib64/bonobo/servers/TVN24.server Installed (but unpackaged) file(s) found: /usr/lib/bonobo/servers/TVN24.server /usr/lib/tvn24/tvn24 /usr/lib/tvn24/tvn24.png It seems you gotta make some fixes in Makefile.am. You can easily use sed to this task, e.g: sed -i "s#tvn24dir = .*#tvn24dir = %{_libdir}/tvn24#" Makefile.am sed -i "s#data = .*#data = %{_datadir}/tvn24#" Makefile.am etc. (there aren't many files to install so it may be easier to do that by yourself, instead of fixing Makefile.am) Also there are some hard-coded paths in TVN24.server file, use sed once again to fix them.
Spec URL: http://liviopl.jogger.pl/files/gnome-applet-tvn24.spec SRPM URL: http://liviopl.jogger.pl/files/gnome-applet-tvn24-0.2.8-2.fc7.src.rpm
PS: It is not my first review request, but I'm waiting for a sponsor.
Spec URL: http://liviopl.jogger.pl/files/gnome-applet-tvn24.spec SRPM URL: http://liviopl.jogger.pl/files/gnome-applet-tvn24-0.2.8-3.fc7.src.rpm
REVIEW: * %{?dist} tag present * package licensed under GPLv3, license text included * rpmlint is quiet * source files match upstream * md5sum fine: 384b022405a673ff75307905735904ea * BRs seem well (not checked by mock though) * final provides and requires sane * package doesn't create any new directory and there's nothing wrong with owning * %clean section present * buildroot fine * %files section good * no check suite * no scriptlets required * no subpackages * no .la files * no GUI I'm going to sponsor you. Go to http://fedoraproject.org/wiki/PackageMaintainers/Join now, read point 4 of "get a Fedora Account" and I'll approve your membership. Information on all the things you need to do next you'll find on the site I mentioned above. If you have any problems, questions, feel free to contact me. Good luck!
New Package CVS Request ======================= Package Name: gnome-applet-tvn24 Short Description: Scrolled RSS aggregator for the polish TVN24 channel Owners: liviopl Branches: F-8 InitialCC: liviopl Cvsextras Commits:yes
cvs done.
Package Change Request ====================== Package Name: gnome-applet-tvn24 New Branches: F-7
CVS done.
Thanks for help, Fedora users and developers :) . Package built successfully do F-7, F-8 and devel. Ready for users. Closing as NEXTRELASE.