Spec URL: http://knolderpoor.no-ip.org/rpms/getmail/getmail.spec SRPM URL: http://knolderpoor.no-ip.org/rpms/getmail/getmail-4.7.6-2.fc7.src.rpm Description: getmail is a secure and and easy-to-use mail retriever for POP3, IMAP4, written in python, and a possible replacement for fetchmail. It's available for other distro's since centuries, so here an attempt to get in into the Fedora Extras. It's my first submission and first rpm package, so it wouldn't hurt to have a in-depth review on it ;-).
I would like to add my support to a request for this. There's already a working spec file created by someone else, however, he simply has his own small repository. http://dries.ulyssis.org/rpm/packages/getmail/info.html As the requester says, it has been available in most distributions for a long time. knolderpoor, are you keeping your specfile up to date, that is, upgrading the specfile as getmail gets newer versions? Thank you for requesting this, I was about to fill out a feature request myself. I just tested your specfile, changed the version to the current 4.7.7, and found that it built without any problems.
(In reply to comment #1) > I would like to add my support to a request for this. There's already a > working spec file created by someone else, however, he simply has his own small > repository. > > http://dries.ulyssis.org/rpm/packages/getmail/info.html This is not a small repository... Dries repository is in fact quite huge and it works more or less with dag in rpmforge... In any case it is true that it would be nice to have this package in fedora.
Patrice, you're quite right. :) I'd just taken a quick scan when first looking for a getmail.rpm. (I've put a mention of this request on the getmail mailing list, so perhaps we'll get a little more support.)
(In reply to comment #0) > It's my first submission and first rpm package, so it wouldn't hurt to have a in-depth review on it ;-). Adding NEEDSPONSOR.
I'll review that. Please redo a srpm with the latest version. Also, did you had a look at: http://fedoraproject.org/wiki/PackageMaintainers http://fedoraproject.org/wiki/PackageMaintainers/Join http://fedoraproject.org/wiki/PackageMaintainers/HowToGetSponsored Looking at the spec file, I like personally to have timestamps kept, so in the iconv call, before doing the mv there could be touch -r docs/CHANGELOG w In general adding -q to %setup is preferred, unless there is something special, or you really want to avoid -q.
Just a quick more comments: Very quick comments: * You can check your srpm/binary rpm by rpmlint - %setup is not quiet (as Patrice said) - For non-executable-script rpmlint complaints like --------------------------------------------------------- getmail.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/getmailcore/logging.py 0644 getmail.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/getmailcore/destinations.py 0644 getmail.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/getmailcore/constants.py 0644 ....... --------------------------------------------------------- this means that scripts which don't have executable permissons should not have shabangs. * Files under %_mandir are automatically marked as %doc. ? By the way, would you consider to shorten the length of one line? For me %doc entry is too long to write in one line.
> I would like to add my support to a request for this. There's already a > working spec file created by someone else, however, he simply has his own > small repository. My specfile is based on the original one from dries (see changelog). I have updated spec file & srpm: http://knolderpoor.no-ip.org/rpms/getmail/getmail.spec http://knolderpoor.no-ip.org/rpms/getmail/getmail-4.7.7-1.fc8.src.rpm I've included latest version 4.7.7, and next changes: - no more convert of CHANGELOG (upstream converted to UTF-8) - added -q to %setup - shortened doc line I've already discussed the shebangs with upstream maintainer, but he wants to keep them. I didn't consider patching so far, because a shebang doesn't really hurt much, it's more a cosmetic change. And I would like to keep the package as close as possible to upstream sources. Thanks for all response so far, waiting for more :). Is there way I can speedup the search for a "sponsor"?
You should escape the % in %changelog, by doubling it: getmail.src:58: W: macro-in-%changelog setup getmail.src:59: W: macro-in-%changelog doc I agree that removing shebangs is pointless. the shebangs however are quite wrong since they call python2.3... Not a big deal. Regarding being sponsored, you can comment on other tickets (though you still cannot accept review) CC me (and maybe Mamoru if he wants to), when you do that.
> You should escape the % in %changelog, by doubling it: > > getmail.src:58: W: macro-in-%changelog setup > getmail.src:59: W: macro-in-%changelog doc Didn't know you can run rpmlint against a spec also, but learning... Fixed it: http://knolderpoor.no-ip.org/rpms/getmail/getmail.spec http://knolderpoor.no-ip.org/rpms/getmail/getmail-4.7.7-2.fc8.src.rpm
The timestamp of the source tarball is not kept -rw-rw-r-- 1 dumas dumas 149137 nov 8 17:44 getmail-4.7.7.tar.gz -rw-rw-r-- 1 dumas dumas 149137 nov 20 18:35 ../SOURCES/getmail-4.7.7.tar.gz You can use wget -N, spectool -g on the spec file or the similar curl option.
(In reply to comment #10) > The timestamp of the source tarball is not kept Now it is. I didn't update the version number, because the spec doesn't change, hope that's okay. http://knolderpoor.no-ip.org/rpms/getmail/getmail-4.7.7-2.fc8.src.rpm
Regarding using the same version, I think it would have been better to increment the release, and also increment the release number in the changelog, without adding a new entry, but it is not a big deal. * follow guidelines * free software, license included * rpmlint output about script not executable ignorable * match upstream d6252e8ebe89fb17baaeb9acba707e39 getmail-4.7.7.tar.gz * %files section right APPROVED. I'll sponsor you, just go through the next steps.
Patrice, please change the status of this bug and bug flags appropriately.
Mamoru, don't hesitate to give other comments, if you have some (though I guess that you wouldn't hesitate in any case ;-) I'm leaving the FE-NEEDSPONSOR blocker until I have granted sponsorship.
New Package CVS Request ======================= Package Name: getmail Short Description: POP3, IMAP4 mail retriever Owners: knol Branches: F-8 InitialCC: knol Cvsextras Commits: yes
cvs done.
Build done. Thanks for the review.
getmail-4.7.7-2.fc8 has been pushed to the Fedora 8 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update getmail'
getmail-4.7.7-2.fc8 has been pushed to the Fedora 8 stable repository. If problems still persist, please make note of it in this bug report.
Package Change Request ====================== Package Name: getmail New Branches: el6 Owners: ricky
Git done (by process-git-requests).