Bug 378531 - Review Request: python-xmltramp - xmltramp is a pythonic API for working with XML
Summary: Review Request: python-xmltramp - xmltramp is a pythonic API for working with...
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Parag AN(पराग)
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2007-11-12 18:58 UTC by Dave Malcolm
Modified: 2008-01-21 17:21 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2008-01-21 17:21:37 UTC
Type: ---
panemade: fedora-review+
kevin: fedora-cvs+


Attachments (Terms of Use)

Description Dave Malcolm 2007-11-12 18:58:06 UTC
Spec URL: http://people.redhat.com/dmalcolm/python/python-xmltramp.spec
SRPM URL: http://people.redhat.com/dmalcolm/python/python-xmltramp-2.17-1.src.rpm
Description: 
xmltramp is a simple Pythonic API for working with XML

Comment 1 Parag AN(पराग) 2007-11-13 07:00:02 UTC
rpmlint gave me
python-xmltramp.src: W: summary-not-capitalized xmltramp is a pythonic API for
working with XML
==>Summary doesn't begin with a capital letter.

python-xmltramp.src: W: invalid-license GPL v2
==> should be GPLv2

Also, follow
http://fedoraproject.org/wiki/Packaging/Guidelines#head-0239576e441f9ef53d175c4aec8c12868dffb5ab


Comment 2 Parag AN(पराग) 2007-11-13 07:08:15 UTC
this package should include License text or file.
Ask upstream to release either tarball containing this script and license or ask
them to put license text in that script.

Comment 3 Dave Malcolm 2007-11-13 20:14:25 UTC
Thanks for reviewing this package.  

Re comment #2, it seems simplest to add appropriate header text to the script,
so I've emailed the upstream author requesting he do this (with a proposed patch)

Re comment #1, I've fixed these issues locally, will await a response from
upstream author before posting next version of specfile.

Comment 4 Parag AN(पराग) 2007-12-18 14:12:12 UTC
any updates?

Comment 5 Dave Malcolm 2007-12-18 15:05:12 UTC
I haven't heard back from the upstream author.

Comment 6 Parag AN(पराग) 2008-01-18 14:13:07 UTC
ping?

Comment 7 Dave Malcolm 2008-01-18 14:53:52 UTC
Thanks.  I haven't heard back from the upstream author, so I've emailed
fedora-legal-list asking if comment #2 is a blocker for including this in Fedora
(email is currently awaiting moderator approval)

Comment 8 Dave Malcolm 2008-01-18 18:32:59 UTC
According to tcallawa on fedora-legal-list:
https://www.redhat.com/archives/fedora-legal-list/2008-January/msg00010.html

"Not a blocker, tag it as License: GPLv2 and put a comment in the spec
file about the missing License text."

I've tried to address comment #1; updated spec at:
http://people.redhat.com/dmalcolm/python/python-xmltramp.spec

Updated SRPM at:
http://people.redhat.com/dmalcolm/python/python-xmltramp-2.17-3.src.rpm

Thanks

Comment 9 Parag AN(पराग) 2008-01-21 03:35:46 UTC
APPROVED.

Comment 10 Dave Malcolm 2008-01-21 14:50:14 UTC
New Package CVS Request
=======================
Package Name: python-xmltramp
Short Description: Pythonic API for XML
Owners: dmalcolm
Branches: F-8
InitialCC: 
Cvsextras Commits: yes

Comment 11 Kevin Fenzi 2008-01-21 17:00:25 UTC
cvs done.

Comment 12 Dave Malcolm 2008-01-21 17:21:37 UTC
Imported and built into devel and F8

Thanks for reviewing this


Note You need to log in before you can comment on or make changes to this bug.