Red Hat Bugzilla – Bug 381051
Review Request: R-abind - Combine multi-dimensional arrays
Last modified: 2007-11-30 17:12:22 EST
Spec URL: http://www.auroralinux.org/people/spot/review/new/R-abind.spec
SRPM URL: http://www.auroralinux.org/people/spot/review/new/R-abind-1.1-1.fc8.src.rpm
Combine multi-dimensional arrays. This is a generalization of cbind and rbind.
Takes a sequence of vectors, matrices, or arrays and produces a single array
of the same or higher dimension.
I note that while installing dependencies for this program I got this:
*** Cannot find any Java interpreter
*** Please make sure 'java' is on you PATH or set JAVA_HOME correspondingly
I guess the call to R CMD javareconf in the R %post scriptlet causes this.
This package builds fine with the usual rpmlint complaints:
R-abind.noarch: W: one-line-command-in-%post
R-abind.noarch: W: one-line-command-in-%postun
We should probably pester scop to work around this.
Do you know how to read R test suite output? I still don't, so I can't tell if
the diffs shown in the output are cause for concern or not. The tests all end
with OK, which I'm taking to mean "test passed".
* source files match upstream:
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text not included upstream.
* latest version is being packaged.
* BuildRequires are proper.
* %clean is present.
* package builds in mock (rawhide, x86_64).
* package installs properly
* rpmlint has only the expected complaints
* final provides and requires are sane:
R-abind = 1.1-1.fc9
* %check is present and all tests pass, as far as I can tell.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* scriptlets are OK (R index generation)
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
Cvs done, builds building. Thanks for the review.