Bug 381051 - Review Request: R-abind - Combine multi-dimensional arrays
Summary: Review Request: R-abind - Combine multi-dimensional arrays
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jason Tibbitts
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2007-11-13 21:34 UTC by Tom "spot" Callaway
Modified: 2007-11-30 22:12 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2007-11-20 21:48:13 UTC
Type: ---
Embargoed:
j: fedora-review+
tcallawa: fedora-cvs+


Attachments (Terms of Use)

Description Tom "spot" Callaway 2007-11-13 21:34:12 UTC
Spec URL: http://www.auroralinux.org/people/spot/review/new/R-abind.spec
SRPM URL: http://www.auroralinux.org/people/spot/review/new/R-abind-1.1-1.fc8.src.rpm
Description: 
Combine multi-dimensional arrays. This is a generalization of cbind and rbind.
Takes a sequence of vectors, matrices, or arrays and produces a single array
of the same or higher dimension.

Comment 1 Jason Tibbitts 2007-11-18 02:00:21 UTC
I note that while installing dependencies for this program I got this:

*** Cannot find any Java interpreter
*** Please make sure 'java' is on you PATH or set JAVA_HOME correspondingly

I guess the call to R CMD javareconf in the R %post scriptlet causes this.

This package builds fine with the usual rpmlint complaints:
  R-abind.noarch: W: one-line-command-in-%post 
   /usr/lib/rpm/R-make-search-index.sh
  R-abind.noarch: W: one-line-command-in-%postun 
   /usr/lib/rpm/R-make-search-index.sh
We should probably pester scop to work around this.

Do you know how to read R test suite output?  I still don't, so I can't tell if
the diffs shown in the output are cause for concern or not.  The tests all end
with OK, which I'm taking to mean "test passed".

* source files match upstream:
   f7c0ff0db4719edbb330ec183b1b10478af96345078cf40150efef895154a082  
   abind_1.1-0.tar.gz
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text not included upstream.
* latest version is being packaged.
* BuildRequires are proper.
* %clean is present.
* package builds in mock (rawhide, x86_64).
* package installs properly
* rpmlint has only the expected complaints
* final provides and requires are sane:
   R-abind = 1.1-1.fc9
  =
   /bin/sh
   R
* %check is present and all tests pass, as far as I can tell.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* scriptlets are OK (R index generation)
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.

APPROVED

Comment 2 Tom "spot" Callaway 2007-11-20 21:48:13 UTC
Cvs done, builds building. Thanks for the review.


Note You need to log in before you can comment on or make changes to this bug.