Red Hat Bugzilla – Bug 383501
Review Request: perl-Getopt-Euclid - Build command-line argument parser matching POD
Last modified: 2007-11-30 17:12:22 EST
Spec URL: http://ron.dk/perl-Getopt-Euclid.spec SRPM URL: http://ron.dk/perl-Getopt-Euclid-0.1.0-1.fc8.src.rpm Description: Getopt::Euclid uses your program's own documentation to create a command- line argument parser. This ensures that your program's documented interface and its actual interface always agree. This is my first package, so I'm seeking a sponsor. Thanks.
Builds fine and rpmlint is clean. Let me do a full review....
So, a clean package; I can find nothing to complain about. Which is very rare for a first package (even a Perl one). Congratulations! * source files match upstream: 6444f685d24efd865583fc1973207cc9a303b8edb3f1fd52ab7efc86ec91540b Getopt-Euclid-v0.1.0.tar.gz * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * summary is OK. * description is OK. * dist tag is present. * build root is OK. * license field matches the actual license. * license is open source-compatible. * license text not included upstream. * latest version is being packaged. * BuildRequires are proper. * %clean is present. * package builds in mock (rawhide, x86_64). * package installs properly * rpmlint is silent. * final provides and requires are sane: perl(Getopt::Euclid) perl(Getopt::Euclid::HierDemo) perl-Getopt-Euclid = 0.1.0-1.fc9 = perl(:MODULE_COMPAT_5.8.8) perl(Carp) perl(File::Spec::Functions) perl(Getopt::Euclid) perl(List::Util) perl(re) perl(strict) perl(version) perl(warnings) * %check is present and all tests pass: All tests successful. Files=32, Tests=232, 2 wallclock secs ( 1.36 cusr + 0.49 csys = 1.85 CPU) * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no scriptlets present. * code, not content. * documentation is small, so no -docs subpackage is necessary. * %docs are not necessary for the proper functioning of the package. APPROVED I will sponsor you; go ahead and apply for cvsextras access and I'll click the appropriate button when I see the request.
Thank you for reviewing the package and thank you for sponsoring me. I have applied for cvsextras membership. Thanks.
New Package CVS Request ======================= Package Name: perl-Getopt-Euclid Short Description: Build command-line argument parser matching POD Owners: ron Branches: F-7 F-8 InitialCC: perl-sig Cvsextras Commits: yes
cvs done.
Package Change Request ====================== Package Name: perl-Getopt-Euclid New Branches: F-8 Updated Description: Build command-line argument parser matching POD Something went wrong in my initial cvs request. Only F-7 branch was created and the description was set to 'F-8'.
:( Sorry about that... typo. ;( Should be fixed up now. Feel free to reset the fedora-cvs flag if something further needs fixing up.
Built on Koji (F-7, F-8, devel). Closing. Jason, thank you for your review and for sponsoring me!