Bug 383801 - dmraid needs to generate UUIDs for lib device-mapper
Summary: dmraid needs to generate UUIDs for lib device-mapper
Keywords:
Status: CLOSED WONTFIX
Alias: None
Product: Red Hat Enterprise Linux 4
Classification: Red Hat
Component: dmraid
Version: 4.6
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
: ---
Assignee: Zdenek Kabelac
QA Contact: Corey Marthaler
URL:
Whiteboard:
Depends On: 379911
Blocks:
TreeView+ depends on / blocked
 
Reported: 2007-11-15 03:17 UTC by Ian Kent
Modified: 2011-02-17 12:24 UTC (History)
7 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2011-02-17 12:24:25 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)
Patch to add UUID support to dmraid (1.69 KB, patch)
2007-11-15 03:17 UTC, Ian Kent
no flags Details | Diff

Description Ian Kent 2007-11-15 03:17:02 UTC
+++ This bug was initially created as a clone of Bug #379911 +++

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.5)
Gecko/20070718 Fedora/2.0.0.5-1.fc7 Firefox/2.0.0.5 pango-text

Description of problem:
libdevmapper requires UUIds for mapped devices, which libdmraid doesn't generate
yet.

Version-Release number of selected component (if applicable):
dmraid-1.0.0.rc14

How reproducible:
Always


Steps to Reproduce:
1. run dmraid -ay

Actual Results:


Expected Results:


Additional info:

-- Additional comment from heinzm on 2007-11-13 08:23 EST --
Created an attachment (id=256841)
dmraid libdevmapper UUID creation patch

Comment 1 Ian Kent 2007-11-15 03:17:02 UTC
Created attachment 259301 [details]
Patch to add UUID support to dmraid

Comment 2 Alasdair Kergon 2007-11-15 12:02:59 UTC
+	/* DM_UUID_LEN is defined in dm-ioctl.h as 129 characters;
+	 * though not all 129 must be used (md uses just 16 from 
+	 * a quick review of md.c. 
+	 * We will be using: (len vol grp name)*/

It's not obvious from glancing at those patches - please would you describe the
*how* you are generating the uuids with examples of what they look like?  What
subsystem prefix do you propose for example?

Comment 3 Heinz Mauelshagen 2007-11-15 16:39:14 UTC
Like the patch stands, the system wide unique RAID set name is being used.
In case a subsystem prefix is mandatory, why not use "dmraid" ?

Comment 4 Alasdair Kergon 2007-11-15 22:39:31 UTC
So put it in capitals, then we get:
  DMRAID-<unique RAID set name>
alongside:
  LVM-<LVID>
when people generate a device listing, so they can see at a glance which program
created the device.

Similarly if the code does any queries, it should ignore devices that don't have
a uuid starting with that prefix (and the newer libdevmapper tree manipulation
functions take the prefix as an argument to support that).  When lvm is
processing a stack of dm devices, this is how it knows at which layer to stop.

Comment 5 Heinz Mauelshagen 2007-11-16 11:48:02 UTC
Subsystem prefix patch for dmraid filed as an attachment to Fedora 7 bz#379911
to be promoted to Fedora 8, RHEL5.2 and RHEL4.7.

Comment 6 RHEL Program Management 2007-11-29 03:55:17 UTC
This request was evaluated by Red Hat Product Management for inclusion in a Red
Hat Enterprise Linux maintenance release.  Product Management has requested
further review of this request by Red Hat Engineering, for potential
inclusion in a Red Hat Enterprise Linux Update release for currently deployed
products.  This request is not yet committed for inclusion in an Update
release.

Comment 7 Suzanne Logcher 2008-05-28 21:27:09 UTC
Unfortunately this bugzilla was not resolved in time for RHEL 4.7 Beta.
It has now been proposed for inclusion in RHEL 4.8 but must regain Product
Management approval.

Comment 8 RHEL Program Management 2008-10-31 16:43:17 UTC
This request was evaluated by Red Hat Product Management for
inclusion, but this component is not scheduled to be updated in
the current Red Hat Enterprise Linux release. If you would like
this request to be reviewed for the next minor release, ask your
support representative to set the next rhel-x.y flag to "?".

Comment 14 Alasdair Kergon 2011-02-17 12:24:25 UTC
The fix got into RHEL5, 6 and upstream, but not RHEL4, which has just had it's last update, so it's too late now.


Note You need to log in before you can comment on or make changes to this bug.