Bug 388721 - /usr/include/linux/cdrom.h should include limits.h
Summary: /usr/include/linux/cdrom.h should include limits.h
Keywords:
Status: CLOSED NOTABUG
Alias: None
Product: Fedora
Classification: Fedora
Component: kernel
Version: 8
Hardware: All
OS: Linux
low
low
Target Milestone: ---
Assignee: Kernel Maintainer List
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2007-11-17 19:51 UTC by David Juran
Modified: 2008-02-14 23:25 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2008-02-14 23:25:39 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description David Juran 2007-11-17 19:51:18 UTC
Description of problem:
/usr/include/linux/cdrom.h is referring to INT_MAX but does not do an include in
 limit.h where it is defined. So any program that does an include on
linux/cdrom.h will fail compiling

Version-Release number of selected component (if applicable):
kernel-headers-2.6.23.1-49.fc8

How reproducible:
Every time

Comment 1 Chuck Ebbert 2007-11-19 21:33:28 UTC
That fix was rejected on linux-kernel.

Comment 2 Christopher Brown 2008-02-13 22:40:14 UTC
Hi David,

I'm reviewing this bug as part of the kernel bug triage project, an attempt to
isolate current bugs in the Fedora kernel.

http://fedoraproject.org/wiki/KernelBugTriage

Do you want this one leaving open or is it dead? Looks like dvd+rw-tools has
been patched with the include if that is the app you were concerned about...

Comment 3 David Juran 2008-02-14 18:35:54 UTC
IMHO a header file should include all other header files from which it uses
symbols but if Chuck says that the upstream disagrees with me I guess there's
not much to do...

Comment 4 Christopher Brown 2008-02-14 23:25:39 UTC
Yeah, here's the discussion if you're interested...

http://lkml.org/lkml/2007/11/10/54

Closing NOTABUG but feel free to re-open if this situation changes.


Note You need to log in before you can comment on or make changes to this bug.