Bug 38909 - RFE: anaconda crashes on wrong entry in %packages section of kickstart file
Summary: RFE: anaconda crashes on wrong entry in %packages section of kickstart file
Alias: None
Product: Red Hat Linux
Classification: Retired
Component: anaconda
Version: 7.1
Hardware: i686
OS: Linux
Target Milestone: ---
Assignee: Brent Fox
QA Contact: Brock Organ
Keywords: FutureFeature
Depends On:
TreeView+ depends on / blocked
Reported: 2001-05-03 10:06 UTC by Dimitri Papadopoulos
Modified: 2007-04-18 16:33 UTC (History)
1 user (show)

Clone Of:
Last Closed: 2001-07-03 22:03:57 UTC

Attachments (Terms of Use)
kickstart file, crashes anaconda (3.60 KB, text/plain)
2001-05-03 15:49 UTC, Dimitri Papadopoulos
no flags Details
Comment (419.75 KB, text/plain)
2001-05-03 10:06 UTC, Dimitri Papadopoulos
no flags Details

Description Dimitri Papadopoulos 2001-05-03 10:06:45 UTC
Created attachment 915079 [details]

(This comment was longer than 65,535 characters and has been moved to an attachment by Red Hat Bugzilla).

Comment 1 Brent Fox 2001-05-03 15:28:15 UTC
Can you attach your kickstart file so that we can have a look?

We don't currently do any sanity checking for kickstart files.  This is
something we will consider for a future release.

Comment 2 Dimitri Papadopoulos 2001-05-03 15:49:33 UTC
Created attachment 17246 [details]
kickstart file, crashes anaconda

Comment 3 Dimitri Papadopoulos 2001-05-03 15:54:32 UTC
The above kickstart should crash anaconda although I don't have the original one
anynore. Also passwords and IP addresses are scrambled.

I suspect the error will also happen if you specify a package that does not
such as 'xemaaacs' - not only when you add a comment after the package.

Comment 4 Brent Fox 2001-05-09 16:11:34 UTC
I have verified the problem.

Comment 5 Need Real Name 2001-05-20 19:28:34 UTC
I encountered the same problem. Although not with additional text after a '#' character.

I use a modified RedHat os CD with a modified comps file. For installation I use kickstart from floppy.

Upgrading from 7.0 to 7.1 getty_ps is no longer on the distribution CD.

When I created the installation set of CD and floppy for 7.1, genhdlist did not complain that it could not find the package 'getty_ps' while building
the hdlist-files. It would be nice if it did. On the first test anaconda crashed as soon as in went into the stage of package dependencies.

Looking at this it would be posible that anaconda also crashes in a 'handcontroled' installation when in comps there is a component that is 
not in the RPM dir. I haven't tested this though.

An error message or ignoring the package is a nicer way to handle this.

Comment 6 Brent Fox 2001-05-21 17:58:31 UTC
I'm more concerned with the installer crashing over '#' chars rather than bogus
packages.  A certain level of experience is assumed with kickstart installs, so
we assume that the user won't put packages that don't exist (such as emaaaaacs)
in the kickstart file.  Just skipping the package can be dangerous, though.  For
example, if the user misspelled glibc as 'gliibc', and the installer just
ignores the packages because there's no 'gliibc' package in the RPMS directory,
then what happens is that the real glibc never gets installed and the user is
left with a broken system.  I think that crashing is more desirable than that. 
Perhaps the installer should display a dialog saying "This package cannot be
found.  Installation aborting." or something like that.

Comment 7 Dimitri Papadopoulos 2001-05-22 06:14:12 UTC
Yes, a dialog displaying the incriminated line would be just fine.
This way we don't have to look for the error in strack traces or log files.

Comment 8 Greg Morgan 2001-06-25 01:05:06 UTC
Ok. If # is illegal in the $packages section, then would you please state that 
in the redhat 7.1 customization guide?  Depending on what you decide about the 
# in or not in the %packages, I'd say that this is also a documentation bug.  
Perhaps a few more examples in section 2.6.x would also help.

Comment 9 Brent Fox 2001-06-26 18:19:20 UTC
Yeah, I agree.  Although it would be easier to change the docs, I think that the
installer *ought* to allow for '#'s in the packages section.  I can see where
people would want to make comments beside certain packages so that other people
can know why they need to be installed.

Comment 10 Brent Fox 2001-07-03 22:03:51 UTC
Committed a fix for this in cvs.  The installer should scan the %packages
section and chop off any "#" chars and everything after it.

Note You need to log in before you can comment on or make changes to this bug.