Red Hat Bugzilla – Bug 39231
The MAXFAIL patch for ppp-watch from bug #10639 is broken (fix available)
Last modified: 2014-03-16 22:20:42 EDT
The patch to make ppp-watch honor MAXFAIL option is broken. It calls ifup-ppp the second time immidiately after it has already been called. Therefore: a) forced redial makes ppp-watch exit prematurely b) busy line makes ppp-watch give up after just two attempts c) ppp-watch exits after first disconnect and ifdown does not work afterwards - pppd has to be killed by hand All this because the second ifup-ppp reports a "can't lock port" error to ppp-watch making it exit with an error. I've created a very simple patch to fix this and I'd really appreciate if it was integrated into rawhide (or even better, pushed as an errata, if you consider it severe enough).
Created attachment 17469 [details] A fix for MAXFAIL
The current implementation doesn't seem to allow for infinite retries. To fix this one could allow for negative MAXFAIL values which should be interpreted as: REALLY PERSIST, keep on trying. The test after incrementing dialCount should be changed from: if ( dialCount < maxfail ) { to: if ( maxfail < 0 || dialCount < maxfail ) {
Infinite retries are actually possible without your proposed change: simply set the MAXFAIL to 0 (zero) or omit it alltogether from your ifcfg file. That's because in the sources all this maxfail stuff is prefixed by if ( maxfail != 0 ) {
Thanks, the fix will be in initscripts-5.88-1.
Any hint as to when initscripts-5.88-1 will be available?
Where is this errata? PERSIST=yes doesn't work as it should (I assume because of this bug) on a number of my servers and it's giving me major headaches.