Spec URL: http://people.redhat.com/caolanm/hyphen/hyphen.spec SRPM URL: http://people.redhat.com/caolanm/hyphen/hyphen-2.3-1.fc9.src.rpm Description: "hyphen" is the hyphenation library split out of OpenOffice.org, having a separate package allows us to update it in isolation from OOo and gives a basis for then including hyphenation rules that are not current part of OOo but are desirable e.g. swedish rules.
I don't see any use of having Requires: pkgconfig as this package does not install any .pc file.
Sure, updated that little niggle as Spec URL: http://people.redhat.com/caolanm/hyphen/hyphen.spec SRPM URL: http://people.redhat.com/caolanm/hyphen/hyphen-2.3-2.fc9.src.rpm
Review: + package builds in mock (development i386). + rpmlint is silent for SRPM and for RPM. + source files match upstream. f0a2f9368253850b1b29e45bbc780f1f hyphen-2.3.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc files present. + BuildRequires are proper. + Compiler flags are honoured correctly. + defattr usage is correct. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code. + no static libraries. + no .pc file present. + -devel subpackage exists. + no .la files. + no translations are available. + Does owns the directories it creates. + no duplicates in %files. + file permissions are appropriate. + ldconfig scriptlets are used. + Package hyphen-2.3-2.fc9 -> Provides: libhyphen.so.0 Requires: libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1) libc.so.6(GLIBC_2.1.3) libc.so.6(GLIBC_2.3.4) libc.so.6(GLIBC_2.4) libhyphen.so.0 + Package hyphen-devel-2.3-2.fc9 -> Requires: /usr/bin/perl hyphen = 2.3-2.fc9 libhyphen.so.0 + Not a GUI app. APPROVED.
New Package CVS Request ======================= Package Name: hyphen Short Description: A hyphenation library Owners: caolanm Branches: devel Cvsextras Commits: yes
cvs done.
Thanks mate for the quick review, I appreciate the turnaround.