Bug 396131 - Review Request: munipack - MuniPack is a CCD photometry package
Summary: Review Request: munipack - MuniPack is a CCD photometry package
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Lubomir Rintel
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Keywords:
Depends On: 396121
Blocks:
TreeView+ depends on / blocked
 
Reported: 2007-11-22 22:49 UTC by Marek Mahut
Modified: 2009-01-07 18:09 UTC (History)
3 users (show)

(edit)
Clone Of:
(edit)
Last Closed: 2007-12-05 10:02:25 UTC
lkundrak: fedora-review+
a.badger: fedora-cvs+


Attachments (Terms of Use)

Description Marek Mahut 2007-11-22 22:49:14 UTC
Spec URL: http://mmahut.fedorapeople.org/reviews/munipack/munipack.spec
SRPM URL: http://mmahut.fedorapeople.org/reviews/munipack/munipack-0.3.1-1.src.rpm

Description: MuniPack is a CCD photometry package. Using MuniPack on a Linux server means that you have a powerful tool for redution of scientific CCD images.

Comment 1 Lubomir Kundrak 2007-11-22 22:57:28 UTC
We agreed with Marek, that I'll spend my precious time reviewing his package,
taking this.

Comment 2 Lubomir Kundrak 2007-11-26 19:53:11 UTC
FC=/usr/bin/f95 ./configure

It is not obvious why you do this, and not %configure. Please add a comment.

Doesn't build for me on Fedora 8/x86_86 

checking for ffclos in -lcfitsio... no
configure: no cfitsio library found

Please check installation of cfitsio and try again.
Look at http://heasarc.gsfc.nasa.gov/fitsio for more information.

Comment 3 Lubomir Kundrak 2007-11-26 19:58:10 UTC
You probably meant to BuildRequire cfitsio-devel instead of cfitsio.
This fixes the build.

RPMlint reports:

munipack.src:26: E: configure-without-libdir-spec
munipack.src: W: mixed-use-of-spaces-and-tabs (spaces: line 3, tab: line 1)

First one is addressed by using %configure, as noted in comment #2
The second one is obvious.

Comment 4 Marek Mahut 2007-11-26 21:17:13 UTC
Spec file and source rpm updated.

Comment 5 Lubomir Kundrak 2007-11-27 11:37:51 UTC
Thanks for the package! All the outstainding issues were addressed, the package
now builds cleanly, with rpmlint silent and has a very nicely written SPEC file :)

Therefore, the package is

APPROVED

The only issue that might be worth fixing is that you install shell script
darkbad and a binary darkbat.bin into bindir, and similarly for flabat. I assume
that the shell scripts are wrappers for the binary files. If it is the case,
libexecdir might be better place for the .bin files. Please consult FHS.

Comment 6 Marek Mahut 2007-12-03 21:14:47 UTC
Thank you Lubomir.

New Package CVS Request
=======================
Package Name: munipack
Short Description: MuniPack is a CCD photometry package
Owners: mmahut@redhat.com
Branches: devel
InitialCC: fedora-astronomy-list@redhat.com
Cvsextras Commits: yes

Comment 7 Toshio Ernie Kuratomi 2007-12-04 02:20:32 UTC
Hi Marek, I'll have to set up the fedora-astronomy-list in the account system in
order to do this.  Is the list associated with a SIG?  Is it already setup as a
bugzilla alias?

Comment 8 Marek Mahut 2007-12-04 06:18:25 UTC
Hello Toshio,

Yes, http://fedoraproject.org/wiki/SIGs/Astronomy

Comment 9 Toshio Ernie Kuratomi 2007-12-04 06:56:03 UTC
Thanks Marek!  Created the astronomy-sig user to send email to
fedora-astronomy-list.

cvs done.

Comment 10 Marek Mahut 2007-12-05 10:02:25 UTC
Thank you very much all!


Note You need to log in before you can comment on or make changes to this bug.