Red Hat Bugzilla – Bug 396131
Review Request: munipack - MuniPack is a CCD photometry package
Last modified: 2009-01-07 13:09:29 EST
Spec URL: http://mmahut.fedorapeople.org/reviews/munipack/munipack.spec
SRPM URL: http://mmahut.fedorapeople.org/reviews/munipack/munipack-0.3.1-1.src.rpm
Description: MuniPack is a CCD photometry package. Using MuniPack on a Linux server means that you have a powerful tool for redution of scientific CCD images.
We agreed with Marek, that I'll spend my precious time reviewing his package,
It is not obvious why you do this, and not %configure. Please add a comment.
Doesn't build for me on Fedora 8/x86_86
checking for ffclos in -lcfitsio... no
configure: no cfitsio library found
Please check installation of cfitsio and try again.
Look at http://heasarc.gsfc.nasa.gov/fitsio for more information.
You probably meant to BuildRequire cfitsio-devel instead of cfitsio.
This fixes the build.
munipack.src:26: E: configure-without-libdir-spec
munipack.src: W: mixed-use-of-spaces-and-tabs (spaces: line 3, tab: line 1)
First one is addressed by using %configure, as noted in comment #2
The second one is obvious.
Spec file and source rpm updated.
Thanks for the package! All the outstainding issues were addressed, the package
now builds cleanly, with rpmlint silent and has a very nicely written SPEC file :)
Therefore, the package is
The only issue that might be worth fixing is that you install shell script
darkbad and a binary darkbat.bin into bindir, and similarly for flabat. I assume
that the shell scripts are wrappers for the binary files. If it is the case,
libexecdir might be better place for the .bin files. Please consult FHS.
Thank you Lubomir.
New Package CVS Request
Package Name: munipack
Short Description: MuniPack is a CCD photometry package
Cvsextras Commits: yes
Hi Marek, I'll have to set up the fedora-astronomy-list in the account system in
order to do this. Is the list associated with a SIG? Is it already setup as a
Thanks Marek! Created the astronomy-sig user to send email to
Thank you very much all!