Bug 396741 - Review Request: powerpc-utils-papr - Utilities for PAPR platforms
Summary: Review Request: powerpc-utils-papr - Utilities for PAPR platforms
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
Target Milestone: ---
Assignee: Josh Boyer
QA Contact: Fedora Extras Quality Assurance
Depends On:
TreeView+ depends on / blocked
Reported: 2007-11-23 13:34 UTC by David Woodhouse
Modified: 2008-10-11 14:39 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Last Closed: 2008-10-11 14:39:27 UTC
Type: ---
jwboyer: fedora-review+
jwboyer: fedora-cvs+

Attachments (Terms of Use)
Pass CFLAGS on link (1.42 KB, patch)
2007-11-27 20:32 UTC, Josh Boyer
no flags Details | Diff

Description David Woodhouse 2007-11-23 13:34:40 UTC
Spec URL: http://david.woodhou.se/ppc64-utils/powerpc-utils-papr.spec
SRPM URL: http://david.woodhou.se/ppc64-utils/powerpc-utils-papr-1.0.4-1.fc9.src.rpm
Description: Utilities for IBM PowerPC PAPR platforms

We used to ship this as part of the ppc64-utils package. That package should die, because it's a mess.

Comment 1 Jason Tibbitts 2007-11-23 20:27:38 UTC
A koji scratch build failed:

make 'CFLAGS=-O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions
-fstack-protector --param=ssp-buffer-size=4 -m64 -mtune=generic' -j2
Building cmds files...
CC cmds/activate_fw.o
activate_fw.c:35:21: error: librtas.h: No such file or directory

Comment 3 Josh Boyer 2007-11-27 20:32:57 UTC
Created attachment 270181 [details]
Pass CFLAGS on link

Without the attached patch I get the following error when building for ppc64:

CC cmds/sys_ident.o
LD cmds/activate_firmware
/usr/bin/ld: powerpc:common64 architecture of input file `activate_fw.o' is
incompatible with powerpc:common output
activate_fw.o: In function `main':
relocation truncated to fit: R_PPC64_REL24 against `rtas_activate_firmware'
collect2: ld returned 1 exit status
make[1]: *** [activate_firmware] Error 1
make[1]: *** Waiting for unfinished jobs....
make: *** [all] Error 2
error: Bad exit status from /var/tmp/rpm-tmp.22169 (%build)

Comment 4 Josh Boyer 2007-11-27 21:13:25 UTC
Ignore the above comment.  It builds fine for me in mock.

Comment 5 Josh Boyer 2007-11-27 21:50:10 UTC
 - Package meets naming and packaging guidelines
 - Spec file matches base package name.
 - Spec has consistant macro usage.
 - Meets Packaging Guidelines.
 - License
 - License field in spec matches
 - License file included in package
 - Spec in American English
 - Spec is legible.
 - Sources match upstream md5sum: 1472a4b2c6929a5bfe0d29ff30e8b559

 - Package needs ExcludeArch
 - BuildRequires correct
 - Package has %defattr and permissions on files is good.
 - Package has a correct %clean section.
 - Package has correct buildroot
      %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
 - Package is code or permissible content.
 - Packages %doc files don't affect runtime.

 - Package compiles and builds on at least one arch.
 - Package has no duplicate files in %files.
 - Package doesn't own any directories other packages own.
 - Package owns all the directories it creates.
 - No rpmlint output.


 - Should build in mock.
 - Should build on all supported archs
 - Should function as described.
 - Should have sane scriptlets.
 - Should have subpackages require base package with fully versioned depend.
 - Should have dist tag
 - Should package latest version

One minor issue:

The URL for the package is actually http://powerpc-utils.ozlabs.org/releases/
not http://powerpc-utils-papr.ozlabs.org/releases/

I'll assum the minor issue above will be fixed before the package is committed.


Comment 6 David Woodhouse 2007-11-27 22:02:28 UTC
New Package CVS Request
Package Name: powerpc-utils-papr
Short Description: Utilities for PAPR platforms
Owners: dwmw2
Branches: F-8
Cvsextras Commits: yes

Comment 7 Brian Pepple 2008-05-25 20:54:51 UTC
David, has this package been built?  If so, this bug can be closed.

Comment 8 Peter Robinson 2008-10-11 14:39:27 UTC
Closing - in rawhide

Note You need to log in before you can comment on or make changes to this bug.