Spec URL: http://nboyle.fedorapeople.org/qemu-launcher.spec SRPM URL: http://nboyle.fedorapeople.org/qemu-launcher-1.7.4-1.fc8.src.rpm Description: Qemu Launcher provides a graphical front-end to all basic, and many advanced QEMU computer emulator options. It allows you to create, save, and run multiple virtual machine configurations, create and convert disk images.
rpmlint gave qemu-launcher.i386: E: no-binary The package should be of the noarch architecture because it doesn't contain any binaries.
(In reply to comment #1) > rpmlint gave > qemu-launcher.i386: E: no-binary > The package should be of the noarch architecture because it doesn't contain > any binaries. Done. Updated file: Spec URL: http://nboyle.fedorapeople.org/qemu-launcher.spec SRPM URL: http://nboyle.fedorapeople.org/qemu-launcher-1.7.4-1.fc8.src.rpm I also caught some other changes to make: Changed group to Applications/Emulators I'm no longer patching the Makefile. Until I saw an example in another spec file, it wasn't obvious to me that it was possible to change Makefile variables in the make install command (ex: make install PREFIX="/usr"), but I get that now. :) I've left the patch for the desktop file, as I'm not sure of any other elegant way to handle alterations to that.
> Updated file: > Spec URL: http://nboyle.fedorapeople.org/qemu-launcher.spec > SRPM URL: http://nboyle.fedorapeople.org/qemu-launcher-1.7.4-1.fc8.src.rpm Minor correction, actual SRPM is http://nboyle.fedorapeople.org/qemu-launcher-1.7.4-2.fc8.src.rpm
need one more update here 1)directory is not owned by package? /usr/share/qemu-launcher 2) any specific need to have %clean as rm -rf %{buildroot}/%{prefix} and not simple rm -rf %{buildroot} 3) good to keep timestamps of files from upstream tarball http://fedoraproject.org/wiki/Packaging/Guidelines#head-0239576e441f9ef53d175c4aec8c12868dffb5ab =>you may like to patch Makefile for that.
(In reply to comment #4) > need one more update here > 1)directory is not owned by package? > /usr/share/qemu-launcher I was globbing the files in /usr/share/qemu-launcher, instead of just specifying the directory. Fixed. > 2) any specific need to have %clean as > rm -rf %{buildroot}/%{prefix} and not simple rm -rf %{buildroot} No good reason I know of. Fixed. > 3) good to keep timestamps of files from upstream tarball I grabbed a timestamp preserved copy from upstream, and am now patching the Makefile to preserve timestamps on install. Updated files: http://nboyle.fedorapeople.org/qemu-launcher.spec http://nboyle.fedorapeople.org/qemu-launcher-1.7.4-3.fc8.src.rpm
Review: + package builds in mock (development i386). + rpmlint is silent for SRPM and for RPM. + source files match upstream. bd71fd543bd2723c7ea54de81f7ccabf qemu-launcher_1.7.4.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc files present. + BuildRequires are proper. + defattr usage is correct. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code. + no static libraries. + no .pc file present. + no -devel subpackage exists. + no .la files. + translations are available. + Does owns the directories it creates. + no duplicates in %files. + file permissions are appropriate. + gtk-update-icon-cache scriptlets are used. + Desktop files installed correctly. + GUI app. APPROVED.
New Package CVS Request ======================= Package Name: qemu-launcher Short Description: A graphical front-end to Qemu virtual machines Owners: nboyle Branches: F-7 F-8 InitialCC: Cvsextras Commits: yes
cvs done.
Package built for F-7, F-8 and, rawhide. Closing ticket.
qemu-launcher-1.7.4-4.fc8 has been pushed to the Fedora 8 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update qemu-launcher'
qemu-launcher-1.7.4-4.fc7 has been pushed to the Fedora 7 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update qemu-launcher'
qemu-launcher-1.7.4-4.fc8 has been pushed to the Fedora 8 stable repository. If problems still persist, please make note of it in this bug report.
qemu-launcher-1.7.4-4.fc7 has been pushed to the Fedora 7 stable repository. If problems still persist, please make note of it in this bug report.