Bug 400651 - GFS: wrong locking order in gfs_get_parent()
Summary: GFS: wrong locking order in gfs_get_parent()
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 5
Classification: Red Hat
Component: gfs-kmod
Version: 5.1
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
: ---
Assignee: Kiersten (Kerri) Anderson
QA Contact: GFS Bugs
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2007-11-27 09:53 UTC by Vasily Averin
Modified: 2010-01-12 03:27 UTC (History)
2 users (show)

Fixed In Version: RHBA-2008-0348
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2008-05-21 15:37:18 UTC
Target Upstream Version:


Attachments (Terms of Use)
Fix wrong locking order in gfs_get_parent() (458 bytes, patch)
2007-11-27 09:53 UTC, Vasily Averin
no flags Details | Diff


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2008:0348 0 normal SHIPPED_LIVE gfs-kmod bug fix update 2008-05-20 12:47:43 UTC

Description Vasily Averin 2007-11-27 09:53:21 UTC
Dmitry Monakhov from OpenVZ linux kernel team reports about wrong locking order
in gfs_get_parent(). Almost all coresponding places was fixed in
gfs-kmod-0.1.19-7.el5, but gfs_get_parrent() was missed.

The problem is fixed by attached patch.

Comment 1 Vasily Averin 2007-11-27 09:53:21 UTC
Created attachment 269561 [details]
Fix wrong locking order in gfs_get_parent()

Comment 2 Wendy Cheng 2007-11-27 15:06:53 UTC
This is probably an oversight of mine while doing last round of NFS fixes.
Will check into this. 

Comment 3 Wendy Cheng 2008-01-02 15:08:32 UTC
Patch checked into CVS today - should be ready for RHEL 5.2.

Comment 4 Wendy Cheng 2008-01-02 15:10:17 UTC
CVSROOT:	/cvs/cluster
Module name:	cluster
Branch: 	RHEL5
Changes by:	wcheng@sourceware.org	2008-01-02 15:07:07

Modified files:
	gfs-kernel/src/gfs: ops_export.c 

Log message:
        Dmitry Monakhov from OpenVZ linux kernel team reports about wrong
        locking order in gfs_get_parent(). Patch submitted by Vasily Averin
        (vvs@sw.ru) under Red Hat bugzilla 400651

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/cluster/gfs-kernel/src/gfs/ops_export.c.diff?cvsroot=cluster&only_with_tag=RHEL5&r1=1.8.2.3&r2=1.8.2.4

Comment 10 errata-xmlrpc 2008-05-21 15:37:18 UTC
An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on the solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHBA-2008-0348.html



Note You need to log in before you can comment on or make changes to this bug.