Bug 406171 - 3.7: Description field in the bug status table.
Summary: 3.7: Description field in the bug status table.
Alias: None
Product: Bugzilla
Classification: Community
Component: Bugzilla General
Version: 3.2
Hardware: All
OS: Linux
medium vote
Target Milestone: ---
Assignee: Noura El hawary
QA Contact:
Whiteboard: 2 hours for selenium testing
Depends On:
Blocks: RHBZ30UpgradeTracker 427052
TreeView+ depends on / blocked
Reported: 2007-11-30 16:58 UTC by David Lawrence
Modified: 2013-06-24 04:15 UTC (History)
0 users

Clone Of:
Last Closed: 2008-02-15 01:05:16 UTC

Attachments (Terms of Use)
patch that we applied to rh_bugzilla_2_18 to have use the new desription field in the bug status table (10.35 KB, text/plain)
2007-12-19 15:48 UTC, Noura El hawary
no flags Details
patch to pull out status description from bug status table (3.22 KB, patch)
2008-02-12 17:46 UTC, Noura El hawary
nelhawar: review-
Details | Diff
bug status description patch (1.77 KB, patch)
2008-02-14 14:11 UTC, Noura El hawary
no flags Details | Diff
Bug status description patch (dkl) (8.28 KB, patch)
2008-02-14 20:00 UTC, David Lawrence
no flags Details | Diff

Description David Lawrence 2007-11-30 16:58:06 UTC
Red Hat has added an additional column to the bug_status table to keep the description for each status. The description is used in show_bug.cgi to display whenever a user mouses over one of the statuses in the drop down field.

Function Requirements:
Additional column needs to be added to the bug_status table. A description should be added for each status in the table. globals.pl needs to be updated to load the data into the bug_status_desc hash for use by template/en/default/bug/knob.html.tmpl.

Comment 1 Noura El hawary 2007-12-19 15:48:20 UTC
Created attachment 290035 [details]
patch that we applied to rh_bugzilla_2_18 to have use the new desription field in the bug status table

Comment 2 Noura El hawary 2007-12-19 15:56:16 UTC
LOC estimation Using Historical data:

From the attached patch in the previous comment#1 ,, The lines of code we wrote
to replace hardcoded bug status description with descriptions from new column
bug_status.description were about 50 LOC

For unit testing:

Selenium test will be generated for this case. it will be approximately 30 LOC
,, Usually in Selenium each action we perform in the web UI is one line of code
, like filling in an input box, clicking a button , verifying data each one of
those is one line of code ,, so by imagining the test and the number of actions
that will be done for this test , I would say it will take 30 LOC

so Total LOC = 50 + 30 = 80 LOC

Comment 3 Noura El hawary 2007-12-19 15:57:10 UTC
Note ,, background for this ticket can be rt:

Comment 4 Kevin Baker 2007-12-19 16:00:47 UTC
Noura, when coming up with the LOC did you look at the upstream code to see if 
there had been major changes around the status field? In other words, is it as 
simple as copying the existing code from 2.18 to 3.2 or do you have to start 

Comment 5 Noura El hawary 2007-12-19 17:11:46 UTC
OK Looking at the 2.18 and 3.2 code basically in 2.18 most of the work to pull
out the bug_status description and generate the legal values for it is done in
globals.pl ,, however this file is deleted in 3.2 and its code is spreaded in
Bugzilla/*.pm modules ,, looking into those modules ,, I think that similar
amount of code that we have in the patch will be used to have that functionality
in 3.2 only it will be spread out in different modules Bugzilla/Field.pm ,
Bugzilla/Bug.pm and Bugzilla/Status.pm instead of globals.pl ,, and it should be
easy to add bug_status description to 3.2 and they have tidy well structured
Status.pm module that will ease the process.

Comment 6 Noura El hawary 2007-12-20 13:40:30 UTC
Note changes selenium test estimation from LOC estimation to time estimation

Comment 7 Noura El hawary 2008-02-12 17:46:16 UTC
Created attachment 294687 [details]
patch to pull out status description from bug status table

Please note that all this patch does is convert the multiple radio buttons of
the bug statuses to a single radio button with a drop down menu, and it
displays the status description when the mouse is moved over the status name in
the drop down menu. however bugzilla doesn't function properly with this patch
in terms of changing the status and the resolution.

for this patch to work 2 things are required:
1- table bug_status is created with description column and populated with the
status descriptions.
2- table status_workflow is populated with the right data that reflects redhat
bugzilla statuses.


Comment 8 Noura El hawary 2008-02-12 17:48:29 UTC
3 hours analyzing the problem and figuring out how to convert our code to work
in the upstream code.
2 hours coding and testing

Comment 9 Noura El hawary 2008-02-14 14:11:20 UTC
Created attachment 294911 [details]
bug status description patch

This patch should pull out the bug status description from the database table
bug_status if you move the mouse over bug status radio buttons it should
display the bug status description.


Comment 10 David Lawrence 2008-02-14 20:00:47 UTC
Created attachment 294941 [details]
Bug status description patch (dkl)

Hey Noura, your patch looked good. I made a couple of changes and attached
another patch with the changes I made for you to look at.

1. I moved the mouse over title to the label so that if you hover over the
sentence "Change status to <STATUS>" it will display the title instead of just
the knob radio button.
2. I update editvalues.cgi and the the templates to allow us to edit the status
description from the admin UI. This way we wont need to bother sysadmins with
doing manual changes via SQL.

I have tested this patch on bugdev and all seems to work properly.

Let me know what you think.

Comment 11 Noura El hawary 2008-02-15 01:03:12 UTC
Hi Dave,

The latest patch looks good :). I will commit it to cvs.


Comment 12 David Lawrence 2008-03-27 18:50:45 UTC
Comment on attachment 294911 [details]
bug status description patch

Clearing review flag for attachment 294911 [details] since 294941 was committed.

Comment 13 Noura El hawary 2008-11-12 06:09:10 UTC
ignore comment please

Note You need to log in before you can comment on or make changes to this bug.