Problem:

defparams -> Bugzilla::Config -> doeditparams has no way of telling if a param
should be an integer value let alone an
integer range. What is needed is a superior way of confining a parameter to a
value type and a range of values.

Homework:

This is a problem in 2.18, don't know if it is still an issue in 3.0.


Solution:

Use Params::Validate to check input. Work this into the upstream

Target:

3.0 still treats integers as single line text values but they have a
checker function called check_numeric
that we could utilize for now.

sub check_numeric {
my ($value) = (@_);
if ($value !~ /^[0-9]+$/) {
return "must be a numeric value";
}
return "";
}

Add that to defparams.pl and then in the cookie_expire_days section make it

{
name => 'cookie_expire_days',
desc => 'Number of days before the stored session cookies will
expire. Also determines the ' .
'number of days that internal code will clean out stale
cookies if older than lastused value.',
type => 't',
default => '',
checker => \&check_numeric,
},

doeditparams.cgi should pick this up and error if the value is not
positive integer.

Voting for future Bugzilla features will be opening soon. Announcement of start date will be posted to the bugzilla-development-list and other broader audience.

Dave

Red Hat Bugzilla is now using version 3.4 of the Bugzilla codebase and
therefore this feature will need to be implemented against the new release.
Updating bug version to 3.2.

Red Hat has now upgraded to Bugzilla 3.6 and this bug will now be reassigned to that version. It would be helpful to the Bugzilla Development Team if this bug is verified to still be an issue with the latest version. If it is no longer an issue, then feel free to close, otherwise please comment that it is still a problem and we will try to address the issue as soon as we can.

Thanks
Bugzilla Development Team

As part of the recent Bugzilla 2.4 upgrade the Bugzilla team are cleaning up bugs opened against old versions of Bugzilla. This bug has been flagged as an old bug and will be CLOSED WONTFIX in 7 days time.

If you believe this bug is an issue in the latest Bugzilla version please comment on this bug within 7 days. Doing so will ensure this bug is not closed automatically.

Thanks, the Bugzilla team.

As noted previously, the Bugzilla Team is cleaning up a large number of outstanding issues that have bit rotted. This bug is being closed as there has been no response to that notification.

If you believe this bug is still important please reopen this bug in the NEW status and PM will consider it.