Bug 406791 - Please upgrade F-7 to a version which knows the Encoding entry is deprecated
Please upgrade F-7 to a version which knows the Encoding entry is deprecated
Status: CLOSED WONTFIX
Product: Fedora
Classification: Fedora
Component: desktop-file-utils (Show other bugs)
7
All Linux
low Severity low
: ---
: ---
Assigned To: Ray Strode [halfline]
Fedora Extras Quality Assurance
:
Depends On:
Blocks: F7Update
  Show dependency treegraph
 
Reported: 2007-11-30 13:41 EST by Hans de Goede
Modified: 2008-05-01 05:33 EDT (History)
2 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2008-05-01 05:33:31 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---


Attachments (Terms of Use)
Do not error on missing encoding (837 bytes, patch)
2007-11-30 15:56 EST, Christopher Stone
no flags Details | Diff

  None (edit)
Description Hans de Goede 2007-11-30 13:41:03 EST
Hi,

Can you please upgrade the F-7 version of desktop=file-utils to a version which
knows the Encoding entry is deprecated, with the current version things get
confusing with reviews when the reviewer is using F-7 and the packager F-8, see
bug 398791 for example.

Also see:
http://standards.freedesktop.org/desktop-entry-spec/desktop-entry-spec-latest.html#deprecated-items

Thanks!
Comment 1 Ray Strode [halfline] 2007-11-30 13:58:05 EST
hmm, i'm not sure.  The problem is, IIRC, the F-8 version of desktop-file-utils
is a lot more pedantic about things and may break rebuilds and such. 
Comment 2 Hans de Goede 2007-11-30 14:37:04 EST
Maybe just patch the current version to not complain about a missing Encoding entry?
Comment 3 Ray Strode [halfline] 2007-11-30 15:05:22 EST
sounds reasonable
Comment 4 Christopher Stone 2007-11-30 15:56:25 EST
Created attachment 274311 [details]
Do not error on missing encoding

Quick fix, if this looks okay to you, I will go ahead and check this into CVS
and do a build.  Then all you have to do is push it.

I've tested this patch on F-7 and it looks like it works here.
Comment 5 Ray Strode [halfline] 2007-11-30 19:42:17 EST
sure looks fine, feel free to commit and build.
Comment 6 Christopher Stone 2007-11-30 22:28:01 EST
Built and ready to be pushed.

http://koji.fedoraproject.org/koji/taskinfo?taskID=268193
Comment 7 Fedora Update System 2007-12-03 06:47:30 EST
desktop-file-utils-0.12-5.fc7 has been pushed to the Fedora 7 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update desktop-file-utils'
Comment 8 Ignacio Vazquez-Abrams 2008-01-29 02:50:26 EST
New problem (desktop-file-utils-0.12-5.fc7):

+ desktop-file-install --vendor=fedora --remove-category Application
--dir=/var/tmp/xmlcopyeditor-1.1.0.6-2.fc7-root-ignacio/usr/share/applications
/var/tmp/xmlcopyeditor-1.1.0.6-2.fc7-root-ignacio/usr/share/applications/xmlcopyeditor.desktop
/var/tmp/xmlcopyeditor-1.1.0.6-2.fc7-root-ignacio/usr/share/applications/xmlcopyeditor.desktop:
missing encoding  (guessed UTF-8)
/var/tmp/xmlcopyeditor-1.1.0.6-2.fc7-root-ignacio/usr/share/applications/fedora-xmlcopyeditor.desktop:
warning: file contains key "Encoding", usage of this key is not recommended,
since it has been deprecated

So now it's adding a deprecated key, and turning around and complaining about it.
Comment 9 Hans de Goede 2008-05-01 05:33:31 EDT
Closing this as F-7 is going EOL real soon now. I guess it would be best to
unpush the update from updates-testing, as that still has issues.


Note You need to log in before you can comment on or make changes to this bug.