Hi, Can you please upgrade the F-7 version of desktop=file-utils to a version which knows the Encoding entry is deprecated, with the current version things get confusing with reviews when the reviewer is using F-7 and the packager F-8, see bug 398791 for example. Also see: http://standards.freedesktop.org/desktop-entry-spec/desktop-entry-spec-latest.html#deprecated-items Thanks!
hmm, i'm not sure. The problem is, IIRC, the F-8 version of desktop-file-utils is a lot more pedantic about things and may break rebuilds and such.
Maybe just patch the current version to not complain about a missing Encoding entry?
sounds reasonable
Created attachment 274311 [details] Do not error on missing encoding Quick fix, if this looks okay to you, I will go ahead and check this into CVS and do a build. Then all you have to do is push it. I've tested this patch on F-7 and it looks like it works here.
sure looks fine, feel free to commit and build.
Built and ready to be pushed. http://koji.fedoraproject.org/koji/taskinfo?taskID=268193
desktop-file-utils-0.12-5.fc7 has been pushed to the Fedora 7 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update desktop-file-utils'
New problem (desktop-file-utils-0.12-5.fc7): + desktop-file-install --vendor=fedora --remove-category Application --dir=/var/tmp/xmlcopyeditor-1.1.0.6-2.fc7-root-ignacio/usr/share/applications /var/tmp/xmlcopyeditor-1.1.0.6-2.fc7-root-ignacio/usr/share/applications/xmlcopyeditor.desktop /var/tmp/xmlcopyeditor-1.1.0.6-2.fc7-root-ignacio/usr/share/applications/xmlcopyeditor.desktop: missing encoding (guessed UTF-8) /var/tmp/xmlcopyeditor-1.1.0.6-2.fc7-root-ignacio/usr/share/applications/fedora-xmlcopyeditor.desktop: warning: file contains key "Encoding", usage of this key is not recommended, since it has been deprecated So now it's adding a deprecated key, and turning around and complaining about it.
Closing this as F-7 is going EOL real soon now. I guess it would be best to unpush the update from updates-testing, as that still has issues.