Description of problem: when cronolog is used with the -l (or equivalents like -H and -S) it won't be able to update that link if any of the following common situations happen : 1) log file the link is pointing to gets deleted 2) log file the link is pointing to is bigger than 2GB in 32bit environments Version-Release number of selected component (if applicable): 1.6.2-6 (or any other previous release) How reproducible: Always Steps to Reproduce: 1. start cronolog with -l 2. either delete the linked file (not the link) or wait until it goes over 2GB in a 32bit architecture 3. wait for cronolog to try to rotate the log Actual results: link is never updated until process is restarted and link manually deleted Expected results: link should be updated normally Additional info: first case reported upstream and has a proposed fix (now upstream site is down so it can't be retrieved from there) which was meant to be included in the next release. the patch is available as part of the gentoo package for cronolog and a cache of the report can be retrieved from google from : http://209.85.173.104/search?q=cache:AxeDmxZhraUJ:cronolog.org/patches/cronolog-missing-symlink-patch.txt+cronolog-missing-symlink-patch.txt&hl=en&ct=clnk&cd=2&gl=us&client=firefox-a since the affected function doesn't have any valid error detection and the proposed patch doesn't support case 2, a different fix is proposed which has also the added benefit of protecting against similar failures when using the -P parameter
Created attachment 277591 [details] removes stat calls (which can fail) and use unchecked calls directly
Comment on attachment 277591 [details] removes stat calls (which can fail) and use unchecked calls directly disregard this patch, the logic got mixed up by excesive refactoring, but the principle is still valid (stat calls are not valid when testing for the existence of symlinks and since there is no error checking they are irrelevant anyway when unlink could be called instead and the error ignored)
Created attachment 279871 [details] remove stat calls for the links and use unlink directly essentially the same patch posted before, and even if it looks confusing because of the unified patch format has been validated to be correct with all combination of affected flags "-S, -H, -l, -P" and for both cases reported. upstreamed patch (or suggestion for a patch) also covers both cases out of luck and the fact that there is no error checking in that function, but the logic is incorrect as it still stats the linked file and not the link for prevlinkname (-P) and relies on the fact that even when that fails the link is overwritten by the following rename call. for a test case do (in a system with more than 2GB of memory, or a very fast disk with ample free disk space) cat /dev/zero | cronolog -l log %Y%m%d%H%M.log
upstream is back online with the following being a report of this bug which was never resolved (from the "Known Bugs" page in http://cronolog.org/bugs.html) : http://cronolog.org/mailing-list/msg00259.html and this being the proposed fix which is the one that was referenced on that old cached record : http://cronolog.org/patches/cronolog-missing-symlink-patch.txt
the jumbo patch (all patches are linked into the "patches" page in http://cronolog.org/patches/index.html) and that was meant to be part of release 1.7.0 which never got out of beta, has a different implementation of this solution which extends the original fix to also uses lstat for prevlinkname (because using stat is logically incorrect as I mentioned earlier) and as can be seen in : http://cronolog.org/patches/cronolog-jumbo-patch.txt a similar fix was re-implemented while looking for a solution to this bug and later discarded and replaced by the proposed fix, because even though it adds a little more error checking and is logically correct it is not portable (and portability for it wasn't checked at "configure" time) and the final solution is more complex and still missing error checking for the other calls (rename and unlink) and therefore not complete.
cronolog.org is no more. You might want to submit these patches to the new GitHub upstream repo: https://github.com/fordmason/cronolog FYI EPEL 5 is going EOL soon: https://lists.fedoraproject.org/archives/list/epel-devel@lists.fedoraproject.org/message/PFGUA4UNOCICASB6W7JLNBL7EJ6L4J2X/
Fedora EPEL 5 changed to end-of-life (EOL) status on 2017-03-31. Fedora EPEL 5 is no longer maintained, which means that it will not receive any further security or bug fix updates. As a result we are closing this bug. If you can reproduce this bug against a currently maintained version of Fedora or Fedora EPEL, please feel free to reopen this bug against that version. If you are unable to reopen this bug, please file a new report against the current release. If you experience problems, please add a comment to this bug. Thank you for reporting this bug and we are sorry it could not be fixed.