Spec URL: http://mtasaka.fedorapeople.org/Review_request/tzclock/tzclock.spec SRPM URL: http://mtasaka.fedorapeople.org/Review_request/tzclock/tzclock-2.5.5-1.fc8.src.rpm Description: TzClock is an X Window GTK+ graphical Clock that can display the time around the world. It supports multiple faces showing different time zones. There is a stopwatch funtion that is accurate to a tenth of a second, plus there are many other nice features for you to discover. koji scratch build on dist-fc8-updates-candidate is here: http://koji.fedoraproject.org/koji/taskinfo?taskID=275301
Package Review ============== Key: - = N/A x = Check ! = Problem ? = Not evaluated === REQUIRED ITEMS === [x] Package is named according to the Package Naming Guidelines. [x] Spec file name must match the base package %{name}, in the format %{name}.spec. [x] Package meets the Packaging Guidelines. [x] Package successfully compiles and builds into binary rpms on at least one supported architecture. Tested on: x86/64 [x] Rpmlint output: empty [x] Package is not relocatable. [x] Buildroot is correct (%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)) [x] Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x] License field in the package spec file matches the actual license. License type:GPLv2 [x] If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x] Spec file is legible and written in American English. [x] Sources used to build the package matches the upstream source, as provided in the spec URL. SHA1SUM of package: f764dafb6f2b1c6860a90a581dcb2cd6394b9de3 [x] Package is not known to require ExcludeArch [x] All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [-] The spec file handles locales properly. [-] ldconfig called in %post and %postun if required. [x] Package must own all directories that it creates. [-] Package requires other packages for directories it uses. [x] Package does not contain duplicates in %files. [x] Permissions on files are set properly. [x] Package has a %clean section, which contains rm -rf %{buildroot} (or $RPM_BUILD_ROOT). [x] Package consistently uses macros. [x] Package contains code, or permissable content. [-] Large documentation files are in a -doc subpackage, if required. [x] Package uses nothing in %doc for runtime. [-] Header files in -devel subpackage, if present. [-] Static libraries in -devel subpackage, if present. [-] Package requires pkgconfig, if .pc files are present. [-] Development .so files in -devel subpackage, if present. [-] Fully versioned dependency in subpackages, if present. [x] Package does not contain any libtool archives (.la). [x] Package contains a properly installed %{name}.desktop file if it is a GUI application. [x] Package does not own files or directories owned by other packages. === SUGGESTED ITEMS === [x] Latest version is packaged. [x] Package does not include license text files separate from upstream. [-] Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x] Reviewer should test that the package builds in mock. Tested on: devel and F7 [x] Package should compile and build into binary rpms on all supported architectures. Tested on:devel/x86_64 and F7/x86_64 [x] Package functions as described. [x] Scriptlets must be sane, if used. [-] The placement of pkgconfig(.pc) files are correct. [-] File based requires are sane. === Issues === 1. none ================ *** APPROVED *** ================
Thanks! New Package CVS Request ======================= Package Name: tzclock Short Description: GTK+ graphical Clock displaying the time around the world Owners: mtasaka Branches: F-8 F-7 InitialCC: Cvsextras Commits: yes
*** Bug 253549 has been marked as a duplicate of this bug. ***
cvs done.
Rebuilt successfully on all branches, requested on koji to push, closing. Thank you for your review!
(In reply to comment #5) > requested on koji to push requested on bodhi...