Description of problem: Build of kernel module powernow-k8.o unconditionally relies on conditional structure member(s). Version-Release number of selected component (if applicable): kernel-2.6.18-53.1.4.el5 How reproducible: Always Steps to Reproduce: 1. rpm -ivh kernel-2.6.18-53.1.4.el5.src.rpm 2. rpmbuild -bp --target i686 SPEC/kernel.spec 3. Using kernel's menuconfig, disable SMP support, save new config 4. Attempt to rebuild kernel Actual results: arch/i386/kernel/cpu/cpufreq/powernow-k8.c: In function âpowernowk8_initâ: arch/i386/kernel/cpu/cpufreq/powernow-k8.c:1435: error: âstruct cpuinfo_x86â has no member named âbooted_coresâ make[3]: *** [arch/i386/kernel/cpu/cpufreq/powernow-k8.o] Error 1 make[2]: *** [arch/i386/kernel/cpu/cpufreq] Error 2 make[1]: *** [arch/i386/kernel/cpu] Error 2 Expected results: Successful compile. Additional info: That structure member "booted_cores" is #ifdef'd to CONFIG_SMP in file ~/include/asm-x86_64/processor.h
I am well aware that Red Hat does not support user-modified kernels. That said, I think you might want to know that you've painted yourselves into a corner should you ever decide to do a non-SMP kernel again.
(In reply to comment #1) > I am well aware that Red Hat does not support user-modified kernels. That said, > I think you might want to know that you've painted yourselves into a corner > should you ever decide to do a non-SMP kernel again. Hey Steve, You're 100% right in that we do not support user-modified kernels. It is *very* unlikely that we'll ever go back to shipping a UP kernel (see Fedora). OTOH, you do point out a valid bug in our code that, IMO, is easy to fix. I'll point it out to the appropriate people. Thanks :) P.
Created attachment 281231 [details] RHEL5 fix for this issue
Steve, the attached patch should get you moving again and get you a clean compile of the PowerNow driver. Thanks again, P.
(In reply to comment #5) > Steve, the attached patch should get you moving again and get you a clean > compile of the PowerNow driver. Thanks for the quick turn-around, Prarit.
This request was evaluated by Red Hat Product Management for inclusion in a Red Hat Enterprise Linux maintenance release. Product Management has requested further review of this request by Red Hat Engineering, for potential inclusion in a Red Hat Enterprise Linux Update release for currently deployed products. This request is not yet committed for inclusion in an Update release.
in 2.6.18-66.el5dz_test You can download this test kernel from http://people.redhat.com/dzickus/el5
An advisory has been issued which should help the problem described in this bug report. This report is therefore being closed with a resolution of ERRATA. For more information on the solution and/or where to find the updated files, please follow the link below. You may reopen this bug report if the solution does not work for you. http://rhn.redhat.com/errata/RHBA-2008-0314.html