Bug 415791 (netbsd-iscsi-review) - Review Request: netbsd-iscsi - User-space implementation of iSCSI target from NetBSD project
Summary: Review Request: netbsd-iscsi - User-space implementation of iSCSI target from...
Alias: netbsd-iscsi-review
Product: Fedora
Classification: Fedora
Component: Package Review   
(Show other bugs)
Version: rawhide
Hardware: All
OS: Linux
Target Milestone: ---
Assignee: Marek Mahut
QA Contact: Fedora Extras Quality Assurance
Depends On:
TreeView+ depends on / blocked
Reported: 2007-12-07 16:30 UTC by Lubomir Kundrak
Modified: 2008-02-05 19:29 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Last Closed: 2008-02-05 19:29:20 UTC
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
mmahut: fedora-review+
kevin: fedora-cvs+

Attachments (Terms of Use)

Description Lubomir Kundrak 2007-12-07 16:30:34 UTC
SPEC: http://people.redhat.com/lkundrak/SPECS/netbsd-iscsi.spec


NetBSD iSCSI is an iSCSI target following the iSCSI RFC 3720.  It is based
on the BSD-licensed Intel iSCSI reference model.  It has been tried and
tested with the Microsoft iSCSI initiator, version 1.06.

Some random notes:

I used a daily snapshot as formal releases are not available. Now I realize,
that the snapshot tarballs get purged after some time, so I'll probably rebase
this on NetBSD CVS. For now there's no need -- the code is pretty much the same,
and stable.

The code also includes a FUSE-based userspace initiator. Though it is primarily
meant to serve as a testsuite for the target, it might be actually usable, so
I'll consider adding it as a subpackage. On the other hand it might be pertly
unnecessary, as we already have a (kernel-based) initiator that performs better
(and works with this target as well).

I'll explore the possibility of packaging libnbsdcompat to provide non-standard
NetBSD specific functions such as strl* funcions, to make need to have local
copies unnecessary.


netbsd-iscsi.x86_64: W: file-not-utf8 /usr/share/man/man8/iscsi-target.8.gz
netbsd-iscsi.x86_64: W: file-not-utf8 /usr/share/man/man5/targets.5.gz

It is the (c) sign. I might as well replace it, as it adds na ugly banner to the
manual pages:

XXX WARNING: old character encoding and/or character set

Comment 1 Lubomir Kundrak 2007-12-07 17:36:48 UTC
I'll need to write the init script as well.

Comment 3 Lubomir Kundrak 2007-12-18 15:11:38 UTC
Nobody loves NetBSD iSCSI?
*sad panda*

Comment 4 Marek Mahut 2007-12-18 20:23:46 UTC
 + Package is named according to the Package Naming Guidelines.
 + Spec file name must match the base package %{name}, in the format %{name}.spec.
 + Package meets the Packaging Guidelines.
 + Package successfully compiles and builds into binary rpms on at least one
supported architecture.
     Tested on: Fedora rawhide
 + Rpmlint output is sane.
 + Buildroot is correct
(%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n))
 + Package is licensed with an open-source compatible license and meets other
legal requirements as defined in the legal section of Packaging Guidelines.
 + License field in the package spec file matches the actual license.
     License type: BSD
 + Spec file is legible and written in American English.
 + Package is not known to require ExcludeArch
 + Package must own all directories that it creates.
 + Package does not contain duplicates in %files.
 + Permissions on files are set properly.
 + Package has a %clean section, which contains rm -rf of the buildroot
 + Package consistently uses macros.
 + File based requires are sane.


Comment 5 Lubomir Kundrak 2007-12-18 20:30:09 UTC
New Package CVS Request
Package Name: netbsd-iscsi
Short Description: User-space implementation of iSCSI target from NetBSD project
Owners: lkundrak
Branches: EL-4 EL-5 F-7 F-8
Cvsextras Commits: yes

Comment 6 Kevin Fenzi 2007-12-19 02:25:09 UTC
cvs done.

Comment 7 Lubomir Kundrak 2007-12-19 20:43:51 UTC
Danke Schon Kevin, Marek. Imported and built.

Note You need to log in before you can comment on or make changes to this bug.