Spec URL: http://people.redhat.com/dlutter/yum/spec/rubygem-gem2rpm.spec SRPM URL: <srpm info here> Description: Generate source rpms and rpm spec files from a Ruby Gem. The spec file tries to follow the gem as closely as possible, and be compliant with the Fedora rubygem packaging guidelines
Ugh .. forgot the SRPM URL: http://people.redhat.com/dlutter/yum/SRPMS/rubygem-gem2rpm-0.5.2-1.src.rpm
- Source0: is not a URL, see: https://fedoraproject.org/wiki/Packaging/SourceURL Is there a better URL than http://rubyforge.org/frs/download.php/29000/gem2rpm-0.5.2.gem? The 29000 is annoying, because it needs to be adjusted with every release. - rpmlint: ok (silent) - builds on koji: ok - http://koji.fedoraproject.org/koji/taskinfo?taskID=294761 - naming: ok - License: ok (GPLv2+ or Ruby) & included - Buildroot: ok I will complete this review later, gtg.
- the package does not own the directories it creates: $ LANG=C rpm -qf /usr/lib/ruby/gems/1.8/gems/gem2rpm-0.5.2/ file /usr/lib/ruby/gems/1.8/gems/gem2rpm-0.5.2 is not owned by any package Afaik, adding this to %files should fix this: %dir %{geminstdir} - changelog entries: normally, the e-mail address is within <> and not within () - gem source: md5sum matches: 9182e2864337b3dc92f49e87b2d8d8a6 gem2rpm-0.5.2.gem 9182e2864337b3dc92f49e87b2d8d8a6 gem2rpm-0.5.2.gem.1 The source URL needs to be fixed and the missing directory needs to be owned, then I will approve this package.
Thanks for the review. I addressed all your points above: Spec URL: http://people.redhat.com/dlutter/yum/spec/rubygem-gem2rpm.spec SRPM URL: http://people.redhat.com/dlutter/yum/SRPMS/rubygem-gem2rpm-0.5.2-2.src.rpm
Sorry for slowing this down, I do not have the time currently.
I see this is assigned to Paul but he hasn't made any comments and fedora-review is not set. What's up? Is this currently under review?
Will review this evening.
Checksum of source does not match Source0 from url. lftpget http://gems.rubyforge.org/gems/gem2rpm-0.5.2.gem [pnasrat@fedora-8-vm SPECS]$ sha1sum gem2rpm-0.5.2.gem ../SOURCES/gem2rpm-0.5.2.gem 1d6194dc1e46fc2ff37f6c8aac068ab7302b3345 gem2rpm-0.5.2.gem cc6ae4ac42dc49d515626916e7c51168c343da8d ../SOURCES/gem2rpm-0.5.2.gem
The rubygem-gem2spec.spec in data.tar.gz differs as it is the spec for the package and has the fixes, I guess you either need to release a point version or do 0.5.3 with the packaging fixes, or use the original rubyforge gem and not generated gem from svn.
David - any chance of addressing the point I made in Comment #8 and #9?
Sorry for the long delay; I've now released 0.5.3 upstream and updated the RPM: SRPM: http://people.redhat.com/dlutter/yum/SRPMS/rubygem-gem2rpm-0.5.3-1.src.rpm Specfile: http://people.redhat.com/dlutter/yum/spec/rubygem-gem2rpm.spec
Ping - Paul, can you have another look ? Should be very close to done now.
rpmlint silent builds fine naming ok license matches buildroot ok follows spec conventions Build in mock Conforms to guidelines Source sha1 matches Source0 All good
New Package CVS Request ======================= Package Name: rubygem-gem2rpm Short Description: Generate rpm specfiles from gems Owners: lutter stahnma Branches: F-8 F-9 EL-5 InitialCC: Cvsextras Commits: yes
cvs done.
Imported and built successfully; Build info: http://koji.fedoraproject.org/koji/buildinfo?buildID=49223