Red Hat Bugzilla – Bug 421231
Review Request: kde-l10n - Internationalization support for KDE
Last modified: 2008-02-19 09:59:08 EST
Spec URL: http://than.fedorapeople.org/kde-l10n.spec SRPM URL: kde-l10m srpm is huge, cannot be uploaded on fedorapeople Description: Internationalization support for KDE
I can review this.
Initial suggestions (consider these as SHOULD items): 1. Drop Epoch. It's a new pkg, shouldn't need it. 2. BuildRequires: kdelibs-devel -> BuildRequires: kdelibs4-devel 3. Requires: kdelibs >= 6:%{version} -> Requires: kde-filesystem 4. for each subpkg, add Provides: %{name}-<locale> = %{version}-%{release} the latter 3 items similar to recent cvs updates to kde-i18n/devel.
I'd say the Epoch one is a MUST (unless there's a repository out there which has the package with the Epoch), we don't want to inflate epochs for no good reason. ;-)
the obove issues have been fixed.
Rex, it's great if you could please review the new kde-l10n.spec file again. The above issues are now fixed. Thanks
%package Chinese-Big5 should be better renamed to %package Chinese-Traditional
Wei-Lun, it's now fixed in new kde-l10n.spec. Thanks
Lacking a buildable pkg atm (to be addressed soon, hopefully), everything else looks good. APPROVED.
New Package CVS Request ======================= Package Name: kde-l10n Short Description: Internationalization support for KDE Owners: than,rdieter,kkofler,ltinkl Branches: InitialCC: Cvsextras Commits: no
cvs done. Any particular reason for the cvsextras: no?
built/included in rawhide now.