Spec URL: http://rishi.fedorapeople.org/starplot-gliese3.spec SRPM URL: http://rishi.fedorapeople.org/starplot-gliese3-0.95-1.fc8.src.rpm Description: Stellar data set for use by the StarPlot tool from the Third Catalogue of Nearby Stars (preliminary edition), Gliese and Jahreiss, 1991. The data set was obtained from the archives of the Astronomical Data Center (ADC) at NASA Goddard Space Flight Center.
Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=295802
rpmlint is silent. source matches upstream. c4f5435c0082bd8b9a7fb2a765f25414 gliese3-0.95.tar.gz mock build is successful. APPROVED.
New Package CVS Request ======================= Package Name: starplot-gliese3 Short Description: Stellar data set for use by the StarPlot tool Owners: rishi Branches: F-7 F-8 InitialCC: Cvsextras Commits: no
Like bug 425853, this srpm must also be fixed.
Okay here scriptlets are having problem. rpm -ihv starplot-gliese3-0.95-1.fc8.noarch.rpm --excludedocs Preparing... ########################################### [100%] 1:starplot-gliese3 ########################################### [100%] *** Does not contain starconvert spec file. error: %post(starplot-gliese3-0.95-1.fc8.noarch) scriptlet failed, exit status 1 Debarshi, Please follow https://bugzilla.redhat.com/process_bug.cgi#c7 and update package.
Please follow https://bugzilla.redhat.com/show_bug.cgi?id=425853#c7 and update package.
We can not distribute the yale5.stars file as part of the package, since it would be a violation of the license. This was discussed on fedora-devel-list (https://www.redhat.com/archives/fedora-devel-list/2007-November/msg00742.html) and it was decided that they should be generated during %post and mentioned as %ghost.
I will use %{_datadir}/%{name} instead of %{_docdir}/%{name}-%{version} to generate the *.stars file. Will that be acceptable?
before you submit any change please cross check with following command rpm -ihv starplot-gliese3-0.95-1.fc8.noarch.rpm --excludedocs
cvs is done, but please fix the scriplet issues before committing.
Proposing this new fix, Spec URL: http://paragn.fedorapeople.org/starplot-gliese3.spec SRPM URL: http://paragn.fedorapeople.org/starplot-gliese3-0.95-2.fc8.src.rpm
IMO it is better that all files (.spec file, orig-data, etc ) from various starplot-related packages are installed under %_datadir/starplot. For this package, IMO it is better that .spec file, orig-data, etc... are installed under %_datadir/starplot/gliese3, and for yale5, it is %_datadir/starplot/yale5.
Spec URL: http://paragn.fedorapeople.org/starplot-gliese3.spec SRPM URL: http://paragn.fedorapeople.org/starplot-gliese3-0.95-3.fc8.src.rpm
Seems good, however please replace gliese3 with %dataset appropriately for consistency.
done :) with same release -3 links. Thanks to you.
Debarshi, Do you see any problem with updated package links in comment #13?
Looks fine to me. Spec: http://rishi.fedorapeople.org/starplot-gliese3.spec SRPM: http://rishi.fedorapeople.org/starplot-gliese3-0.95-1.fc8.src.rpm Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=307172 I have merged Parag's changes into the above Spec/SRPM pair.
Sorry, make it SRPM: http://rishi.fedorapeople.org/starplot-gliese3-0.95-2.fc8.src.rpm
APPROVED above SRPM. You can now import above SRPM.