Bug 426228 - Review Request: perl-Class-Inner - A perlish implementation of Java like inner classes
Summary: Review Request: perl-Class-Inner - A perlish implementation of Java like inne...
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review   
(Show other bugs)
Version: rawhide
Hardware: All Linux
Target Milestone: ---
Assignee: Jason Tibbitts
QA Contact: Fedora Extras Quality Assurance
Depends On:
Blocks: 426230
TreeView+ depends on / blocked
Reported: 2007-12-19 13:18 UTC by Xavier Bachelot
Modified: 2007-12-21 12:42 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Last Closed: 2007-12-21 12:42:57 UTC
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
tibbs: fedora-review+
kevin: fedora-cvs+

Attachments (Terms of Use)

Description Xavier Bachelot 2007-12-19 13:18:35 UTC
Spec URL: http://washington.kelkoo.net/fedora/SPECS/perl-Class-Inner.spec
SRPM URL: http://washington.kelkoo.net/fedora/SRPMS/perl-Class-Inner-0.1-1.fc8.src.rpm
Yet another implementation of an anonymous class with per object overrideable
methods, but with the added attraction of sort of working dispatch to the
parent class's method.

Comment 1 Xavier Bachelot 2007-12-19 16:42:15 UTC
rpmlint gives a clean output.

Comment 2 Jason Tibbitts 2007-12-20 06:09:09 UTC
This failed to build for me due to a missing build dependency on Test::More:

t/basic....Can't locate Test/More.pm in @INC (@INC contains: ...

Adding that gets things to build.

Comment 3 Xavier Bachelot 2007-12-20 08:54:11 UTC
(In reply to comment #2)
> This failed to build for me due to a missing build dependency on Test::More:
> t/basic....Can't locate Test/More.pm in @INC (@INC contains: ...
> Adding that gets things to build.
Yup, seen that at home yesterday night. The strange thing is it did build
properly on my mock setup.

Fixed in http://washington.kelkoo.net/fedora/SRPMS/perl-Test-Unit-0.25-2.fc8.src.rpm

Comment 4 Xavier Bachelot 2007-12-20 08:58:43 UTC
oops, bad link. The good one is

Comment 5 Jason Tibbitts 2007-12-20 21:26:02 UTC
Source URL should probably be http://search.cpan.org/dist/Class-Inner/.

There's usually no reason to put the class name in the summary, since it's
derivable from the package name, but this isn't really a big deal.

I don't see how you came to "GPLv2+ or Artistic 2.0" for the license tag.  All
I can see is that the README says "same as Perl", which is GPL+ or Artistic.

This package puts a file in %{perl_vendorlib}/Class but doesn't own it or
depend on anything that owns it.

* source files match upstream:
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK.
* dist tag is present.
* build root is OK.
X license field does not match the actual license.
* license is open source-compatible.
* license text not included upstream.
* latest version is being packaged.
* BuildRequires are proper.
* %clean is present.
* package builds in mock (rawhide, x86_64).
* package installs properly
* rpmlint is silent.
* final provides and requires are sane:
   perl(Class::Inner) = 0.1
   perl-Class-Inner = 0.1-2.fc9

* %check is present and all tests pass:
   All tests successful.
   Files=1, Tests=13,  0 wallclock secs ( 0.01 cusr +  0.00 csys =  0.01 CPU)

X owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no scriptlets present.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.

Comment 6 Xavier Bachelot 2007-12-20 21:58:41 UTC

Summary, License and URL fixed.
Directory ownership fixed.

Comment 7 Jason Tibbitts 2007-12-20 23:09:40 UTC
Awesome; looks great.  APPROVED

Comment 8 Xavier Bachelot 2007-12-20 23:40:42 UTC
Thanks for the quick review tibbs.

New Package CVS Request
Package Name: perl-Class-Inner
Short Description: A perlish implementation of Java like inner classes
Owners: xavierb
Branches: F-8
Cvsextras Commits: yes

Comment 9 Kevin Fenzi 2007-12-21 04:46:46 UTC
cvs done.

Comment 10 Xavier Bachelot 2007-12-21 12:42:57 UTC
Thanks Kevin.

Package imported and built for devel and F-8.

Note You need to log in before you can comment on or make changes to this bug.