Bug 426320 - [PATCH] Wrong directory ownership on ext* volumes
Summary: [PATCH] Wrong directory ownership on ext* volumes
Alias: None
Product: Fedora
Classification: Fedora
Component: hal
Version: 8
Hardware: All
OS: Linux
Target Milestone: ---
Assignee: David Zeuthen
QA Contact: Fedora Extras Quality Assurance
Depends On:
TreeView+ depends on / blocked
Reported: 2007-12-20 00:50 UTC by Nathaniel McCallum
Modified: 2013-03-06 03:54 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Last Closed: 2009-01-09 05:33:58 UTC

Attachments (Terms of Use)
Patch to fix directory ownership (2.20 KB, patch)
2007-12-20 00:50 UTC, Nathaniel McCallum
no flags Details | Diff
Fix directory ownership (improved) (2.03 KB, patch)
2007-12-20 16:27 UTC, Nathaniel McCallum
no flags Details | Diff

Description Nathaniel McCallum 2007-12-20 00:50:08 UTC
When a user inserts a ext3 formatted USB key (or other removeable drive), it is
correctly mounted (via gnome-volume-manager, gnome-mount & hal).  However, the
mount point is owned by root, making it impossible for the user to modify the
files on the device.

FreeBSD fixed this problem a while back, but enclosed the code in ifdefs for
FreeBSD only.  The attached patch does two things:
1. Make the code NOT FreeBSD only
2. Move chown() code to after mount is complete as mounting resets the ownership

This should probably be vetted for security, though I can't think of anything
wrong with it.

Comment 1 Nathaniel McCallum 2007-12-20 00:50:08 UTC
Created attachment 290086 [details]
Patch to fix directory ownership

Comment 2 Nathaniel McCallum 2007-12-20 16:27:38 UTC
Created attachment 290166 [details]
Fix directory ownership (improved)

Modified the patch slightly:
1. If we can't lookup default gid, just don't change gid.
2. If we can't chown, don't error, just print a warning.

Comment 3 Bug Zapper 2008-11-26 09:05:20 UTC
This message is a reminder that Fedora 8 is nearing its end of life.
Approximately 30 (thirty) days from now Fedora will stop maintaining
and issuing updates for Fedora 8.  It is Fedora's policy to close all
bug reports from releases that are no longer maintained.  At that time
this bug will be closed as WONTFIX if it remains open with a Fedora 
'version' of '8'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version prior to Fedora 8's end of life.

Bug Reporter: Thank you for reporting this issue and we are sorry that 
we may not be able to fix it before Fedora 8 is end of life.  If you 
would still like to see this bug fixed and are able to reproduce it 
against a later version of Fedora please change the 'version' of this 
bug to the applicable version.  If you are unable to change the version, 
please add a comment here and someone will do it for you.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events.  Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

The process we are following is described here: 

Comment 4 Bug Zapper 2009-01-09 05:33:58 UTC
Fedora 8 changed to end-of-life (EOL) status on 2009-01-07. Fedora 8 is 
no longer maintained, which means that it will not receive any further 
security or bug fix updates. As a result we are closing this bug.

If you can reproduce this bug against a currently maintained version of 
Fedora please feel free to reopen this bug against that version.

Thank you for reporting this bug and we are sorry it could not be fixed.

Note You need to log in before you can comment on or make changes to this bug.