Spec URL: http://pfj.fedorapeople.org/mono-basic.spec SRPM URL: http://pfj.fedorapeople.org/mono-basic-1.2.6-1.fc9.src.rpm Description: mono-basic is the visual basic compiler for mono
I'll take this as a bribe for fixing #394851. GOOD: builds cleanly in mock (tested x86_64 Rawhide and i386 F8) Owns all it's file and directories the spec is in clean US English (and nifty sed magic) BAD: GPL/LGPL are no longer valid licenses Summary needs to be capitalized (minor but rpmlint complains so let's shut it up) mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 7) Aside that, the spec seems to comply to packaging standards. Is there any reason to export the language variable?
Fixed the bad bits and removed the export language bit (it was from another spec file)
This seems sane to me.. APPROVED.
Shouldn't the license be LGPLv2+?
I'm not sure. This URL suggests GPLv2 : http://www.t2-project.org/packages/mono-basic.html, as does http://dsrg.mff.cuni.cz/projects/mono/diffs/showdiff.php?old=2005-11-05&new=2005-11-06&diffIndex=14&bench=. However, I've seen it also listed as LGPL. I'll see what upstream has to say.
there is no CVS request here. please follow the directions at http://fedoraproject.org/wiki/PackageMaintainers/CVSAdminProcedure
New Package CVS Request ======================= Package Name: mono-basic Short Description: VB.NET support for mono Owners: pfj Branches: FC7, FC8 InitialCC: pfj Cvsextras Commits: yes
cvs done.
This is in the repos now, CLOSING