Spec URL: http://kurzawa.nonlogic.org/rpm/jabbin/jabbin.spec SRPM URL: http://kurzawa.nonlogic.org/rpm/jabbin/jabbin-2.0-1.beta2a.fc8.src.rpm Description: Jabbin is a Instant messaging and VoIP Jabber client. P.S I'm looking for sponsor.
I will check this later.
Well, before checking this package fully: - This package contains 3rdparty/ directory and uses the libraries under the directory 3party/jrtplib 3party/libjingle 3party/qca However, all these libraries are already in Fedora. Please apply patches against jabbin so that jabbin uses not the internal 3rd parties' libraries but the external system-wide libraries provided as Fedora rpms. - And please fix the versioning. Ref: the subsection "Pre-Release packages" of http://fedoraproject.org/wiki/Packaging/NamingGuidelines
Spec URL: http://kurzawa.nonlogic.org/rpm/jabbin/jabbin.spec SRPM URL: http://kurzawa.nonlogic.org/rpm/jabbin/jabbin-2.0-0.2.beta2a.fc8.src.rpm I fixed version, but I have problem with 3rd parties libraries. I tried to make patch, but the libjingle in Jabbin is quite diffrent than libjingle in Fedora repository is quite different. Libjingle in Fedora hasn't got class PhoneSessionClient and I don't know what should I do.
Well, I tried to check libjingle-0.3.11-5.fc9 and actually all header files under talk/session/phone are marked as noninst_headers (if libjingle does not support mediastreamer). So: please follow below. - You can use libjingle 0.3.11 tarball, unpack it and replace the directory jabbin-2.0beta2a/3party/libjingle/ to use header files missing from libjingle-devel rpm. - However anyway jabbin should not use libjingle.a but should link against libjingle.so in libjingle rpm.
I have got problem. I tried to make a patch which was changing paths to libjingle, qca and jrtplib, but the libingle in Jabbin is quite diffrent than libjingle in Fedora repository and I couldn't build RPM. You said than I should use tarball with libjingle, but I don't know how should this patch look like? What should I do? Here is the link to this patch which I tried to make: http://kurzawa.nonlogic.org/rpm/jabbin/jabbin-pathfix.patch
Please make srpm anyway and attach the build.log so that we can check what you are actually trying to do and where build fails easily.
http://kurzawa.nonlogic.org/rpm/jabbin/build.log But I used here this patch above. I don't use any tarball here, because I don't knoow how should it look like.
Urm.. I quickly tried to use external libjingle but it seems rather difficult... So for now would you use internal libjingle and rewrite (reupload) the new srpm?
Sorry, but I have got problem with my Fedora and I will try to repair this for a few days.
Removed NEED-SPONSOR block, i'll sponsor him.
Ok so I tried to build jabbin with internal libjingle but qca and jrtplib from fedora repository. I made patch: http://kurzawa.nonlogic.org/rpm/jabbin/jabbin-pathfix2.patch I tried to build but I had an error. http://kurzawa.nonlogic.org/logs/jabbin-build.log I think the jrtplib in fedora repository is quite different than jrtplib from jabbin. What should I do?
Well, actually I could not find jabbintransmitter.h in Fedora jrtplib 3.7.1 and I guess jabbin is using (very?) old jrtplib... For now it seems we should use internal jrtplib, too.
I made patch to use qca from fedora repository: http://kurzawa.nonlogic.org/rpm/jabbin/jabbin-pathfix3.patch And I tried to build RPM with this patch, but I have got: http://kurzawa.nonlogic.org/logs/jabbin-build2.log What should I do?
Would you retry, please?
What should I retry?
Created attachment 293909 [details] Patch to use external qca (qca-devel needed) Well, the attached patch should work to use external qca (qca-devel needed). However - Currently Fedora specific compilation flags are not honored - This package fails to build on dist-f9 (rawhide). Rawhide now uses g++43 and jabbin compilation fails with g++43 on many points...
dist-f8-updates-candidate build with the patch in comment 16 applied is here: http://koji.fedoraproject.org/koji/taskinfo?taskID=394937
Fixed Spec URL: http://kurzawa.nonlogic.org/rpm/jabbin/jabbin.spec SRPM URL: http://kurzawa.nonlogic.org/rpm/jabbin/jabbin-2.0-3.beta2a.fc8.src.rpm
As I said in comment 16: - This jabbin doesn't build on g++43 (i.e. rawhide) http://koji.fedoraproject.org/koji/taskinfo?taskID=396315 I tried to fix this, however apparently it requires not a few fixes. I hope I have some time to try on this weekend, however I suggest that you ping to upstream. - Builds on dist-f8-updates-candidate, however Fedora specific compilation flags are not honored correctly. More patches or some sed trick or so is needed.
Created attachment 294471 [details] PATCH: fix compilation with gcc4.3 Mamoru Tasaka asked me to take a look at fixing the gcc-4.3 compilation errors seen in F-9. This patches fixes them.
Fixed Spec URL: http://kurzawa.nonlogic.org/rpm/jabbin/jabbin.spec SRPM URL: http://kurzawa.nonlogic.org/rpm/jabbin/jabbin-2.0-4.beta2a.fc8.src.rpm Thanks for patch!
Created attachment 294496 [details] Patch to honor Fedora cflags correctly Thank you to Hans for fixing gcc43 related issues! For 2.0-0.4: * License ----------------------------------------------------- src/tools/openpgp/gpgproc/ Dual of QPL and GPLv2 (strict) ----------------------------------------------------- - License tag must be GPLv2 (strict). * Compiler flags - Fedora specific compilation flags are not honored correctly. http://koji.fedoraproject.org/koji/taskinfo?taskID=411301 The proposal patch attached fixes this issue. http://koji.fedoraproject.org/koji/taskinfo?taskID=411576 * Timestamps - When using "cp" or "install" commands, please use "-p" option to keep timestamps on installed files. ------------------------------------------------------ install -m 644 certs/readme certs/rootcert.xml $RPM_BUILD_ROOT%{_datadir}/%{name}/certs ------------------------------------------------------ Please fix the 3 issues above before committing into CVS. Other things are okay. ------------------------------------------------------ This package (jabbin) is APPROVED by me ------------------------------------------------------
Fixed Spec URL: http://kurzawa.nonlogic.org/rpm/jabbin/jabbin.spec SRPM URL: http://kurzawa.nonlogic.org/rpm/jabbin/jabbin-2.0-5.beta2a.fc8.src.rpm
New Package CVS Request ======================= Package Name: jabbin Short Description: Instant messaging and VoIP Jabber client Owners: kurzawa Branches: F-7 F-8 InitialCC: Cvsextras Commits: yes
Oops.. The string "strict" is not needed in the spec file, sorry.
cvs done.
Fixed Spec URL: http://kurzawa.nonlogic.org/rpm/jabbin/jabbin.spec SRPM URL: http://kurzawa.nonlogic.org/rpm/jabbin/jabbin-2.0-6.beta2a.fc8.src.rpm
Imported and built. Thanks again for review!