Spec URL: http://berrange.fedorapeople.org/review/perl-Array-Diff/perl-Array-Diff.spec SRPM URL: http://berrange.fedorapeople.org/review/perl-Array-Diff/perl-Array-Diff-0.04-1.fc9.src.rpm Description: This module does the diff of two arrays, and returns added and deleted arrays. It's simple usage of Algorithm::Diff.
You have a missing BRs. check make test output t/002_pod............skipped all skipped: Test::Pod 1.00 required for testing POD t/003_podcoverage....skipped all skipped: Test::Pod::Coverage required for testing pod coverage t/004_diff...........ok All tests successful, 2 tests skipped.
BuildRequires updated... http://berrange.fedorapeople.org/review/perl-Array-Diff/perl-Array-Diff.spec http://berrange.fedorapeople.org/review/perl-Array-Diff/perl-Array-Diff-0.04-2.fc9.src.rpm
Review: + package builds in mock (rawhide). + rpmlint is silent for SRPM and for RPM. + source files match upstream url 7c08993e1d15dfae959b706db23f5a65 Array-Diff-0.04.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test outputs + ./Build test t/001_load...........ok t/002_pod............ok t/003_podcoverage....ok t/004_diff...........ok All tests successful. Files=4, Tests=12, 0 wallclock secs ( 0.30 cusr + 0.04 csys = 0.34 CPU) + Package perl-Array-Diff-0.04-2.fc9 Provides: perl(Array::Diff) = 0.04 APPROVED.
New Package CVS Request ======================= Package Name: perl-Array-Diff Short Description: Diff two arrays Owners: berrange Branches: F-8 InitialCC: Cvsextras Commits: yes
cvs done
$ koji latest-pkg dist-f9 perl-Array-Diff Build Tag Built by ---------------------------------------- -------------------- ---------------- perl-Array-Diff-0.04-2.fc9 dist-f9 berrange
Package Change Request ====================== Package Name: perl-Array-Diff New Branches: EL-6 Owners: berrange
Git done (by process-git-requests).
Hi Daniel, could we have an EPEL-5 branch of this package? I (pghmcfc) would be happy to maintain it if you're not interested. The current Rawhide package builds OK unmodified for EPEL-5.
Package Change Request ====================== Package Name: perl-Array-Diff New Branches: EL-5 Owners: berrange
perl-Array-Diff-0.07-7.el5 has been submitted as an update for Fedora EPEL 5. https://admin.fedoraproject.org/updates/perl-Array-Diff-0.07-7.el5
perl-Array-Diff-0.07-7.el5 has been pushed to the Fedora EPEL 5 stable repository.