Bug 426529 - Review Request: perl-Array-Diff - Diff two arrays
Review Request: perl-Array-Diff - Diff two arrays
Status: CLOSED NEXTRELEASE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Parag AN(पराग)
Fedora Extras Quality Assurance
:
Depends On:
Blocks: 426542
  Show dependency treegraph
 
Reported: 2007-12-21 15:37 EST by Daniel Berrange
Modified: 2012-03-24 15:04 EDT (History)
3 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2007-12-22 13:06:25 EST
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
panemade: fedora‑review+
limburgher: fedora‑cvs+


Attachments (Terms of Use)

  None (edit)
Description Daniel Berrange 2007-12-21 15:37:52 EST
Spec URL: http://berrange.fedorapeople.org/review/perl-Array-Diff/perl-Array-Diff.spec
SRPM URL: http://berrange.fedorapeople.org/review/perl-Array-Diff/perl-Array-Diff-0.04-1.fc9.src.rpm
Description:  
This module does the diff of two arrays, and returns added and deleted arrays. It's simple usage of Algorithm::Diff.
Comment 1 Parag AN(पराग) 2007-12-21 21:59:42 EST
You have a missing BRs.

check make test output
t/002_pod............skipped
        all skipped: Test::Pod 1.00 required for testing POD
t/003_podcoverage....skipped
        all skipped: Test::Pod::Coverage required for testing pod coverage
t/004_diff...........ok
All tests successful, 2 tests skipped.
Comment 3 Parag AN(पराग) 2007-12-21 22:57:45 EST
Review:
+ package builds in mock (rawhide).
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
7c08993e1d15dfae959b706db23f5a65  Array-Diff-0.04.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test outputs
+ ./Build test
t/001_load...........ok
t/002_pod............ok
t/003_podcoverage....ok
t/004_diff...........ok
All tests successful.
Files=4, Tests=12,  0 wallclock secs ( 0.30 cusr +  0.04 csys =  0.34 CPU)

+ Package perl-Array-Diff-0.04-2.fc9
  Provides: perl(Array::Diff) = 0.04

APPROVED.
Comment 4 Daniel Berrange 2007-12-21 23:06:18 EST
New Package CVS Request
=======================
Package Name: perl-Array-Diff
Short Description: Diff two arrays
Owners: berrange
Branches: F-8
InitialCC: 
Cvsextras Commits: yes
Comment 5 Tom "spot" Callaway 2007-12-22 10:55:23 EST
cvs done
Comment 6 Daniel Berrange 2007-12-22 13:06:25 EST
$ koji latest-pkg dist-f9 perl-Array-Diff
Build                                     Tag                   Built by
----------------------------------------  --------------------  ----------------
perl-Array-Diff-0.04-2.fc9                dist-f9               berrange
Comment 7 Daniel Berrange 2010-08-24 06:56:11 EDT
Package Change Request
======================
Package Name: perl-Array-Diff
New Branches: EL-6
Owners: berrange
Comment 8 Kevin Fenzi 2010-08-24 19:47:32 EDT
Git done (by process-git-requests).
Comment 9 Paul Howarth 2012-03-05 08:59:44 EST
Hi Daniel,

could we have an EPEL-5 branch of this package? I (pghmcfc) would be happy to maintain it if you're not interested. The current Rawhide package builds OK unmodified for EPEL-5.
Comment 10 Daniel Berrange 2012-03-06 06:43:55 EST
Package Change Request
======================
Package Name: perl-Array-Diff
New Branches: EL-5
Owners: berrange
Comment 11 Jon Ciesla 2012-03-06 07:57:52 EST
Git done (by process-git-requests).
Comment 12 Fedora Update System 2012-03-06 11:01:22 EST
perl-Array-Diff-0.07-7.el5 has been submitted as an update for Fedora EPEL 5.
https://admin.fedoraproject.org/updates/perl-Array-Diff-0.07-7.el5
Comment 13 Fedora Update System 2012-03-24 15:04:02 EDT
perl-Array-Diff-0.07-7.el5 has been pushed to the Fedora EPEL 5 stable repository.

Note You need to log in before you can comment on or make changes to this bug.