Spec URL: http://rafalzaq.nonlogic.org/fedora/perl-Config-Simple/perl-Config-Simple.spec SRPM URL: http://rafalzaq.nonlogic.org/fedora/perl-Config-Simple/perl-Config-Simple-4.59-1.fc8.src.rpm Description: Simple configuration file class
rpmlint gave me perl-Config-Simple.src: W: invalid-license Artistic ==> it should be GPL+ or Artistic Good to have Source URL as http://cpan.org/authors/id/S/SH/SHERZODR/Config-Simple-%{version}.tar.gz
Fixed. Spec URL: http://rafalzaq.nonlogic.org/fedora/perl-Config-Simple/perl-Config-Simple.spec SRPM URL: http://rafalzaq.nonlogic.org/fedora/perl-Config-Simple/perl-Config-Simple-4.59-2.fc8.src.rpm
Review: + package builds in mock (development i386). + rpmlint is silent for SRPM and for RPM. + source files match upstream url 96513b61c7db591339ce2577878a3b32 Config-Simple-4.59.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test outputs t/bug...............ok t/create............ok t/guess_syntax......ok t/import............ok t/ini...............ok t/is_modified.......ok t/read-rv...........ok t/simple............ok t/simplified-ini....ok t/tie...............ok All tests successful. Files=10, Tests=89, 1 wallclock secs ( 0.33 cusr + 0.08 csys = 0.41 CPU) + Package perl-Config-Simple-4.59-2.fc9-> Provides: perl(Config::Simple) = 4.59 Requires: perl(:MODULE_COMPAT_5.8.8) perl(AutoLoader) perl(Carp) perl(Fcntl) perl(Text::ParseWords) perl(strict) perl(vars) APPROVED.
Thanks for review! New Package CVS Request ======================= Package Name: perl-Config-Simple Short Description: Simple configuration file class Owners: rafalzaq Branches: F-7 F-8 InitialCC: Cvsextras Commits: yes
cvs done.
Imported and built.
Package Change Request ====================== Package Name: perl-Config-Simple New Branches: EL-5 EL-6 Owners: sixy InitialCC: sixy
CVS done (by process-cvs-requests.py).