Bug 426828 - Review Request: perl-XML-Generator-DBI - Generate SAX events from SQL queries
Summary: Review Request: perl-XML-Generator-DBI - Generate SAX events from SQL queries
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Parag AN(पराग)
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Keywords:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2007-12-27 01:29 UTC by Xavier Bachelot
Modified: 2007-12-28 22:30 UTC (History)
2 users (show)

(edit)
Clone Of:
(edit)
Last Closed: 2007-12-28 22:30:06 UTC
panemade: fedora-review+
kevin: fedora-cvs+


Attachments (Terms of Use)

Description Xavier Bachelot 2007-12-27 01:29:04 UTC
Spec URL: http://washington.kelkoo.net/fedora/SPECS/perl-XML-Generator-DBI.spec
SRPM URL: http://washington.kelkoo.net/fedora/SRPMS/perl-XML-Generator-DBI-1.00-2.fc8.src.rpm
Description: This module generates SAX events from SQL queries against a DBI connection.

Comment 1 Parag AN(पराग) 2007-12-27 03:47:06 UTC
you have missing BRs in package. Check make test failed so does make build
http://koji.fedoraproject.org/koji/getfile?taskID=310770&name=build.log

Comment 3 Parag AN(पराग) 2007-12-28 03:28:29 UTC
Review:
+ package builds in mock (rawhide).
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
fff6dad098bfa66a587066e3afb3664e  XML-Generator-DBI-1.00.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test output is
All tests successful.
Files=6, Tests=28,  6 wallclock secs ( 1.08 cusr +  0.09 csys =  1.17 CPU)

+ Package  perl-XML-Generator-DBI-1.00-3.fc9 ->
  Provides: perl(XML::Generator::DBI) = 1.00
  Requires: perl(MIME::Base64) perl(XML::SAX::Base) perl(strict) perl(vars) 

APPROVED.

Comment 4 Xavier Bachelot 2007-12-28 10:58:39 UTC
Thx for the review Parag.

New Package CVS Request
=======================
Package Name: perl-XML-Generator-DBI
Short Description: Generate SAX events from SQL queries
Owners: xavierb
Branches: F-8
InitialCC: 
Cvsextras Commits: yes

Comment 5 Kevin Fenzi 2007-12-28 17:44:41 UTC
cvs done.

Comment 6 Xavier Bachelot 2007-12-28 22:30:06 UTC
Thx Kevin.

Imported and built for devel and F-8.


Note You need to log in before you can comment on or make changes to this bug.