Spec URL: http://washington.kelkoo.net/fedora/SPECS/perl-XML-Generator-DBI.spec SRPM URL: http://washington.kelkoo.net/fedora/SRPMS/perl-XML-Generator-DBI-1.00-2.fc8.src.rpm Description: This module generates SAX events from SQL queries against a DBI connection.
you have missing BRs in package. Check make test failed so does make build http://koji.fedoraproject.org/koji/getfile?taskID=310770&name=build.log
Fixed in : http://washington.kelkoo.net/fedora/SPECS/perl-XML-Generator-DBI.spec http://washington.kelkoo.net/fedora/SRPMS/perl-XML-Generator-DBI-1.00-3.fc8.src.rpm
Review: + package builds in mock (rawhide). + rpmlint is silent for SRPM and for RPM. + source files match upstream url fff6dad098bfa66a587066e3afb3664e XML-Generator-DBI-1.00.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test output is All tests successful. Files=6, Tests=28, 6 wallclock secs ( 1.08 cusr + 0.09 csys = 1.17 CPU) + Package perl-XML-Generator-DBI-1.00-3.fc9 -> Provides: perl(XML::Generator::DBI) = 1.00 Requires: perl(MIME::Base64) perl(XML::SAX::Base) perl(strict) perl(vars) APPROVED.
Thx for the review Parag. New Package CVS Request ======================= Package Name: perl-XML-Generator-DBI Short Description: Generate SAX events from SQL queries Owners: xavierb Branches: F-8 InitialCC: Cvsextras Commits: yes
cvs done.
Thx Kevin. Imported and built for devel and F-8.