Red Hat Bugzilla – Bug 426829
Review Request: perl-XML-Handler-YAWriter - Yet another Perl SAX XML Writer
Last modified: 2007-12-28 17:31:19 EST
Spec URL: http://washington.kelkoo.net/fedora/SPECS/perl-XML-Handler-YAWriter.spec SRPM URL: http://washington.kelkoo.net/fedora/SRPMS/perl-XML-Handler-YAWriter-0.23-2.fc8.src.rpm Description: YAWriter implements Yet Another XML::Handler::Writer.
I see only file mentioned license text is YAWriter.pm:# and/or modify this copy under terms of GNU General Public License. for license and don't see text like this "This program is free software; you can redistribute it and/or modify it under the same terms as Perl itself." so I guess License should be only GPL+
Fixed in : http://washington.kelkoo.net/fedora/SPECS/perl-XML-Handler-YAWriter.spec http://washington.kelkoo.net/fedora/SRPMS/perl-XML-Handler-YAWriter-0.23-3.fc8.src.rpm
Review: + package builds in mock (rawhide). + rpmlint is silent for SRPM and for RPM. + source files match upstream url c7ba2a828a284d6a13ea6fbbfec2b162 XML-Handler-YAWriter-0.23.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test output is 1..5 ok 1 ok 2 ok 3 ok 4 ok 5 ok 6 ok 7 ok 8 +exit 0 + Package perl-XML-Handler-YAWriter-0.23-3.fc9 -> Provides: perl(XML::Handler::YAWriter) Requires: /usr/bin/perl perl(:MODULE_COMPAT_5.8.8) perl(IO::File) perl(XML::Handler::YAWriter) perl(XML::Parser::PerlSAX) perl(strict) perl(vars) APPROVED.
Thx for the review Parag. New Package CVS Request ======================= Package Name: perl-XML-Handler-YAWriter Short Description: Yet another Perl SAX XML Writer Owners: xavierb Branches: F-8 InitialCC: Cvsextras Commits: yes
cvs done.
Thx Kevin. Imported and built for devel and F-8.