Spec URL: http://bart.ulyssis.org/fedora/php-suhosin/php-suhosin.spec SRPM URL: http://bart.ulyssis.org/fedora/php-suhosin/php-suhosin-0.9.22-1.fc8.src.rpm Description: Suhosin is an advanced protection system for PHP installations. It was designed to protect servers and users from known and unknown flaws in PHP applications and the PHP core. Suhosin has saved my several times on servers I maintain by blocking certain exploits in PHP. This isn't the suhosin patch but the extension! This is my first package review request so I'll need a sponsor.
I am not a sponsor so i cannot review your package, i can only comment on it. [root@dhcp1-17 ~]# rpmlint php-suhosin-0.9.22-1.fc8.src.rpm php-suhosin.src: W: invalid-license PHP License See: http://fedoraproject.org/wiki/Licensing Everything else looks ok to me, atleast in the first glance.
Updated, http://bart.ulyssis.org/fedora/php-suhosin/
I can see the newer spec file there, just the new srpm.
A dirty browser cache? I can see it with two different browsers.
Ah my bad. Spec seems ok now Thanks.
As i'm not a sponsor, only a few comments. - lastest version is 0.9.23 - you should requires php(zend-abi) (not php(zend-api)) - use %setup -q -n suhosin-%{version} (which simplify other part) - no need to requires php-common as the php(zend-abi) assure ABI compatibility of extension. It will be great to provides a config file with some recommended value (for ex : suhosin.log.sapi=S_ALL, and probably others) Do you succeed to run the test suite ?
Thanks for the remarks. I'll update it one of the next days.
Created attachment 304019 [details] Updated SPEC file, works for me, only header changed Try this one...
Update spec file and srpm is available at http://bart.ulyssis.org/fedora/php-suhosin/
Would really be nice to have that package ... +1
I will take care about this review. - spec looks fine for me - mock build OK - rpmlint doesn't print any error/warning => Reviewed.
Anyone willing to sponsor me? I've added myself to the packager group and I'm awaiting approval.
I have rereviewed the package and it seems to be OK. I will sponsor you.
Thx. I'm not able to request a cvs module. The select box for the fedora-cvs flag is stilled greyed out -> http://fedoraproject.org/wiki/PackageMaintainers/CVSAdminProcedure What should I do or what am I doing wrong?
Weird, I can set the flag without problems. Perhaps there are some sync problems between bugzilla and Fedora Account System? I think you are member of all the groups you need to be in FAS so that should not be a problem. Can you try to relogin into bugzila and if that doesn't help can you report the problem to the bugzilla-owner ?
The sync between FAS and bugzilla is currently being done manually, about once per day. Reporting this to the bugzilla people is not productive as it is not their fault.
I have added this information to https://fedoraproject.org/wiki/PackageMaintainers/CVSAdminProcedure
New Package CVS Request ======================= Package Name: php-suhosin Short Description: Suhosin extension for the php language Owners: pvrabec Branches: InitialCC:
Bart I don't want to be maintainer of this package I just want it to be available in F10, therefore I filed this CVS request. We can switch as soon as possible.
Thanks. At least for the next I won't be able to do much because I can only access the internet from my work. After that I should have a connection at home again.
Bart / Peter: I see Bart in the packager group... would you like me to process the request with him as owner?
For me this is ok, but I don't have any problem whatsoever if someone else is the owner. I've got the time to maintain it so I would at least want co-maintainership.
(In reply to comment #21) > Bart / Peter: I see Bart in the packager group... would you like me to process > the request with him as owner? Bart: owner me: co-maintainer thnx.
cvs done.
Package were built, closing
Package Change Request ====================== Package Name: php-suhosin New Branches: EL-4 EL-5 Owners: zoeloelip
CVS done.
Can someone please push php-suhosin-0.9.32.1-1.fc14 to updates?