Spec URL: http://terjeros.fedorapeople.org/mytop/mytop.spec SRPM URL: http://terjeros.fedorapeople.org/mytop/mytop-1.6-1.fc8.src.rpm Description: mytop is a console-based tool for monitoring the threads and overall performance of MySQL servers. The user interface is modeled after familiar top application.
Because you manually specify the DBI dependency, your final dependency list ends up with a doubled entry for DBI. You'll need to either filter it or just remove the manual one. Is there something specifically wrong with letting RPM figure it out? All supported Fedora releases, and indeed even RH9 and probably older, have a much more recent version of DBI than the one you require manually, so the versioned requirement is pretty much pointless. * source files match upstream: b17c702598b10bb0ce2695f609122637c799eaaaec1afaa73246b048f07be9bd mytop-1.6.tar.gz * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * summary is OK. * description is OK. * dist tag is present. * build root is OK. * license field matches the actual license. * license is open source-compatible. * license text not included upstream. * latest version is being packaged. * BuildRequires are proper. * %clean is present. * package builds in mock (rawhide, x86_64). * package installs properly * rpmlint is silent. X final provides and requires are sane: mytop = 1.6-1.fc9 = /usr/bin/perl perl >= 0:5.005 perl(DBD::mysql) >= 1 X perl(DBI) X perl(DBI) >= 1.13 perl(Getopt::Long) perl(Socket) perl(Term::ANSIColor) perl(Term::ReadKey) >= 2.1 perl(Time::HiRes) perl(strict) perl(vars) * %check is present and all tests pass: ok 1 Not much there; I installed the built package on a mysql server and it ran fine. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no scriptlets present. * code, not content. * documentation is small, so no -docs subpackage is necessary. * %docs are not necessary for the proper functioning of the package.
> Because you manually specify the DBI dependency, your final dependency list ends > up with a doubled entry for DBI. You'll need to either filter it or just remove > the manual one. Fixed, thanks. spec: http://terjeros.fedorapeople.org/mytop/mytop.spec srpm: http://terjeros.fedorapeople.org/mytop/mytop-1.6-2.fc8.src.rpm
Looks good to me. APPROVED
> APPROVED Thanks, Jason! New Package CVS Request ======================= Package Name: mytop Short Description: A top clone for MySQL Owners: terjeros Branches: F-7 F-8 InitialCC: Cvsextras Commits: yes
cvs done.
Thanks Kevin. Closing, built for rawhide.
Package Change Request ====================== Package Name: mytop New Branches: EL-4 EL-5 Owners: terjeros mmckinst InitialCC: terjeros I emailed terjeros, he does not wish to maintain the EPEL branches. I'd like to maintain the EL-4 and EL-5 branch myself.
Package Change Request ====================== Package Name: mytop New Branches: el5 el6 Owners: terjeros ksyz InitialCC: terjeros > You are welcome to do that as I don't maintain any package in EPEL at > them moment. > > Thanks for taking care of EPEL mytop users. -- terjeros
(In reply to comment #7) > I emailed terjeros, he does not wish to maintain the EPEL branches. I'd like to > maintain the EL-4 and EL-5 branch myself. Hey, you probably didn't set the fedora-cvs flag. When processed, feel free to ask about ACLs.
Git done (by process-git-requests).
mytop-1.7-4.b737f60.el5 has been submitted as an update for Fedora EPEL 5. https://admin.fedoraproject.org/updates/mytop-1.7-4.b737f60.el5
mytop-1.7-4.b737f60.el5 has been pushed to the Fedora EPEL 5 stable repository. If problems still persist, please make note of it in this bug report.
Kevin, When I submitted that change, I didn't realize I had to be a package maintainer before I could set the fedora-cvs flag (still working on getting a sponsor actually). Are you interested in doing mytop for EPEL 4? If not I can take care of EPEL 4.
Err, that should've been addressed to Michal, not Kevin.
(In reply to comment #13) > Are you interested in doing mytop for EPEL 4? If not I can take care of EPEL 4. Not particularly, but after changing source from xz to gzip it builds fine under EL4. I don't have EL4 anywhere around, so if you can test this [1] scratch build, I will request branch for EL4. Feel free to ask about ACLs after you get sponsored. [1] http://koji.fedoraproject.org/koji/taskinfo?taskID=2493885
Michal, I'm officially sponsored now. I'll take care of the EPEL 4 branch.
Package Change Request ====================== Package Name: mytop New Branches: EL-4 Owners: terjeros mmckinst InitialCC: terjeros
Package Change Request ====================== Package Name: mytop New Branches: el4 Owners: terjeros mmckinst InitialCC: terjeros
mytop-1.7-5.b737f60.el4 has been submitted as an update for Fedora EPEL 4. https://admin.fedoraproject.org/updates/mytop-1.7-5.b737f60.el4
mytop-1.7-5.b737f60.el4 has been pushed to the Fedora EPEL 4 stable repository. If problems still persist, please make note of it in this bug report.
Package Change Request ====================== Package Name: mytop New Branches: el6 Owners: terjeros mmckinst InitialCC: terjeros I noticed that mytop was retired from el5 and el6 on 2014-12-17 and would like to take ownership of it to unretire it, so it's available again in EPEL
Barry, I can't tell if you're an official Fedora package maintainer but you need to set the fedora-cvs flag and put your name in the ownership field. For now, I'll take care of the EPEL branches but feel free to take them over if you're an official maintainer. Package Change Request ====================== Package Name: mytop New Branches: el5 el6 epel7 Owners: terjeros mmckinst InitialCC: terjeros
Thanks Mark Not an official fedora package maintainer...new to all this and trying to get my feet wet :)
Barry, EPEL 7 RPM is built and just marked as stable, see bug #1126412 for when it finally hits the stable repo.