Spec URL: http://mmahut.fedorapeople.org/reviews/PySBIG/PySBIG.spec SRPM URL: http://mmahut.fedorapeople.org/reviews/PySBIG/PySBIG-0.04-1.fc8.src.rpm Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=315293 Description: PySBIG can read SBIG CCD files and give you a Numeric array for the data and a dictionary for the headers. There is cPySBIG (since version 0.02) which is 40 times faster than the pure PySBIG module, also included. Version 0.03 now works with numpy instead of Numeric. Does not build on F-8, as we did not respected eggs, this can be ignore, I plan to maintain this for only F-9.
Just add conditional build for F<9: http://www.salstar.sk/pub/fedora/SPECS/PySBIG.spec
Needs Work: PySBIG.x86_64: E: non-standard-executable-perm /usr/lib64/python2.5/site-packages/PySBIGuncompress.so 0775 Why is this one group-writable?
Lubomir, this is strage. It's not my case, [mmahut@mmahut pysbig]$ rpmlint /home/mmahut/build/tree/SRPMS/PySBIG-0.04-2.fc8.src.rpm [mmahut@mmahut pysbig]$ rpmlint /home/mmahut/build/tree/RPMS/i386/PySBIG-0.04-2.fc8.i386.rpm [mmahut@mmahut pysbig]$ rpmlint /home/mmahut/build/tree/RPMS/i386/PySBIG-debuginfo-0.04-2.fc8.i386.rpm [mmahut@mmahut pysbig]$ ll /usr/lib/python2.5/site-packages/PySBIGuncompress.so -rwxr-xr-x 1 root root 3876 2007-12-30 21:29 /usr/lib/python2.5/site-packages/PySBIGuncompress.so [mmahut@mmahut pysbig]$ Spec file updated to support F-8 as well. http://mmahut.fedorapeople.org/reviews/PySBIG/PySBIG-0.04-2.fc8.src.rpm
Some IRC discussion concluded that something weird happening in my mock, that doesn't happen on koji builders, thus the above is not a blocker. APPROVED
Note the issue in comment #2 is bug #432062
New Package CVS Request ======================= Package Name: PySBIG Short Description: PySBIG can read SBIG CCD files Owners: mmahut Branches: F-8 Cvsextras Commits: yes
The short description here isn't very descriptive... Perhaps consider changing it to "python support for reading SBIG CCD files" or something? cvs done.
Kevin, true, I think your proposition is ok. Can you change it please? Thank you Lubomir for the review!
Done.