Red Hat Bugzilla – Bug 427061
Review Request: redmode - Switch to and from night red mode
Last modified: 2009-01-07 13:09:44 EST
Spec URL: http://mmahut.fedorapeople.org/reviews/redmode/redmode.spec SRPM URL: http://mmahut.fedorapeople.org/reviews/redmode/redmode-1.0-1.fc8.src.rpm Rawhide koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=315775 Description: Little shell script for GNOME to change the color theme to red. Useful for astronomers in night.
Please add a comment about upstream above this line -- I guess you keep the source for the tarball in fedora-astronomy repository? Source0: %{name}-%{version}.tar.gz Not a blocker though -- APPROVED
Oops, pardon -- not yet ready for approval. 1.) rpmlint redmode.x86_64: W: non-conffile-in-etc /etc/redmode.conf Please add %config(noreplace) to the corresponding line in %files. Note, if it's not meant to be modifiable by user, it would be better in %{_datadir} 2.) please add BuildArch: noarch so that -debuginfo doesn't get generated, etc. I believe the script is noarch, isn't it?
Lubomir, redmode-1.0-2.fc8.src.rpm updated.
Thanks Marek. All outstanding problems were adressed. RPMLint is silent now and I can't find any more issues. APPROVED
New Package CVS Request ======================= Package Name: redmode Short Description: Switch to and from night red mode Owners: mmahut Branches: F-8 InitialCC: astronomy-sig Cvsextras Commits: yes
cvs done.
Thank you!!!