Bug 427061 (redmode-review) - Review Request: redmode - Switch to and from night red mode
Summary: Review Request: redmode - Switch to and from night red mode
Status: CLOSED RAWHIDE
Alias: redmode-review
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Lubomir Rintel
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Keywords:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2007-12-30 19:24 UTC by Marek Mahut
Modified: 2009-01-07 18:09 UTC (History)
2 users (show)

(edit)
Clone Of:
(edit)
Last Closed: 2008-02-18 16:44:16 UTC
lkundrak: fedora-review+
kevin: fedora-cvs+

Attachments (Terms of Use)
Add an attachment (proposed patch, testcase, etc.)

Description Marek Mahut 2007-12-30 19:24:01 UTC 
Spec URL: http://mmahut.fedorapeople.org/reviews/redmode/redmode.spec
SRPM URL: http://mmahut.fedorapeople.org/reviews/redmode/redmode-1.0-1.fc8.src.rpm
Rawhide koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=315775
Description: Little shell script for GNOME to change the color theme
to red. Useful for astronomers in night.
Comment 1 Lubomir Kundrak 2008-02-08 09:34:42 UTC 
Please add a comment about upstream above this line -- I guess you keep the
source for the tarball in fedora-astronomy repository?

Source0:        %{name}-%{version}.tar.gz

Not a blocker though -- APPROVED
Comment 2 Lubomir Kundrak 2008-02-08 09:39:50 UTC 
Oops, pardon -- not yet ready for approval.

1.) rpmlint

redmode.x86_64: W: non-conffile-in-etc /etc/redmode.conf
Please add %config(noreplace) to the corresponding line in %files.
Note, if it's not meant to be modifiable by user, it would be better in %{_datadir}

2.) please add

BuildArch: noarch

so that -debuginfo doesn't get generated, etc. I believe the script is noarch,
isn't it?
Comment 3 Marek Mahut 2008-02-10 18:26:05 UTC 
Lubomir, redmode-1.0-2.fc8.src.rpm updated.
Comment 4 Lubomir Kundrak 2008-02-10 18:31:49 UTC 
Thanks Marek. All outstanding problems were adressed. RPMLint is silent now and
I can't find any more issues.

APPROVED
Comment 5 Marek Mahut 2008-02-10 22:14:33 UTC 
New Package CVS Request
=======================
Package Name: redmode
Short Description: Switch to and from night red mode
Owners: mmahut
Branches: F-8
InitialCC: astronomy-sig
Cvsextras Commits: yes
Comment 6 Kevin Fenzi 2008-02-11 17:53:33 UTC 
cvs done.
Comment 7 Marek Mahut 2008-02-18 16:44:16 UTC 
Thank you!!!
Note You need to log in before you can comment on or make changes to this bug.