Spec URL: http://mmahut.fedorapeople.org/reviews/nexcontrol/nexcontrol.spec SRPM URL: http://mmahut.fedorapeople.org/reviews/nexcontrol/nexcontrol-0.2-1.fc8.src.rpm Koji rawhide build: http://koji.fedoraproject.org/koji/taskinfo?taskID=315999 Description: NexControl is a perl code to interface with the NexStar series of scopes from Celestron.
I think license here is GPLv2 not GPLv2+
+ rpmlint is silent. + License is open source compatible. - But as license text is not included in source file nexcontrol.pl, license is GPLv2. + spec is clean. + source verified with upstream source URL 7eba08240de22d2baf794b00d9731440 nexcontrol.tar.gz APPROVED. SHOULD: License tag is GPLv2
Thank you for this review, are you sure it's GPLv2? [mmahut@mmahut nexcontrol-0.2]$ grep -c "any later version" LICENSE 2 [mmahut@mmahut nexcontrol-0.2]$
New Package CVS Request ======================= Package Name: nexcontrol Short Description: Software to control your Celestron NexStar Telescope Owners: mmahut Branches: F-8 InitialCC: astronomy-sig Cvsextras Commits: yes
afaik, each .c or any source file should also contain license header to satisfy GPLv2+ You can see that on http://fedoraproject.org/wiki/Licensing, GPLv2 and GPLv2+ points to same License text page => http://www.gnu.org/licenses/old-licenses/gpl-2.0.html But if you want to release it as GPLv2+ then ok.
cvs done.
Thanks!