Bug 427078 - Review Request: nexcontrol - Software to control your Celestron NexStar Telescope
Summary: Review Request: nexcontrol - Software to control your Celestron NexStar Teles...
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Parag AN(पराग)
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2007-12-30 23:26 UTC by Marek Mahut
Modified: 2007-12-31 22:54 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2007-12-31 22:54:05 UTC
Type: ---
Embargoed:
panemade: fedora-review+
kevin: fedora-cvs+


Attachments (Terms of Use)

Description Marek Mahut 2007-12-30 23:26:33 UTC
Spec URL: http://mmahut.fedorapeople.org/reviews/nexcontrol/nexcontrol.spec
SRPM URL: http://mmahut.fedorapeople.org/reviews/nexcontrol/nexcontrol-0.2-1.fc8.src.rpm
Koji rawhide build: http://koji.fedoraproject.org/koji/taskinfo?taskID=315999
Description: NexControl is a perl code to interface with
the NexStar series of scopes from Celestron.

Comment 1 Parag AN(पराग) 2007-12-31 09:01:02 UTC
I think license here is GPLv2 not GPLv2+


Comment 2 Parag AN(पराग) 2007-12-31 09:05:41 UTC
+ rpmlint is silent.
+ License is open source compatible. 
- But as license text is not included in source file nexcontrol.pl, license is
GPLv2.
+ spec is clean.
+ source verified with upstream source URL
  7eba08240de22d2baf794b00d9731440  nexcontrol.tar.gz
APPROVED.

SHOULD:
   License tag is GPLv2

Comment 3 Marek Mahut 2007-12-31 09:26:31 UTC
Thank you for this review, are you sure it's GPLv2?

[mmahut@mmahut nexcontrol-0.2]$ grep -c "any later version" LICENSE 
2
[mmahut@mmahut nexcontrol-0.2]$ 


Comment 4 Marek Mahut 2007-12-31 09:28:49 UTC
New Package CVS Request
=======================
Package Name: nexcontrol
Short Description: Software to control your Celestron NexStar Telescope
Owners: mmahut
Branches: F-8
InitialCC: astronomy-sig
Cvsextras Commits: yes

Comment 5 Parag AN(पराग) 2007-12-31 09:47:57 UTC
afaik, each .c or any source file should also contain license header to satisfy
GPLv2+
You can see that on http://fedoraproject.org/wiki/Licensing, GPLv2 and GPLv2+
points to same License text page =>
http://www.gnu.org/licenses/old-licenses/gpl-2.0.html

But if you want to release it as GPLv2+ then ok.

Comment 6 Kevin Fenzi 2007-12-31 18:05:55 UTC
cvs done.

Comment 7 Marek Mahut 2007-12-31 22:54:05 UTC
Thanks!


Note You need to log in before you can comment on or make changes to this bug.