Description of problem: When building the -62 kernel with the kernel-2.6.18-i686.config, I see the following build warning a few different times: In file included from init/main.c:57: include/asm/setup.h:20:1: warning: "COMMAND_LINE_SIZE" redefined In file included from include/linux/sched.h:42, from include/linux/module.h:9, from init/main.c:15: include/asm/param.h:21:1: warning: this is the location of the previous definition Looking at it with Don, this seems to be new between -58 and -62; I haven't tracked it down further than that.
Created attachment 290758 [details] Patch that should resolve this issue (untested)
This request was evaluated by Red Hat Product Management for inclusion in a Red Hat Enterprise Linux maintenance release. Product Management has requested further review of this request by Red Hat Engineering, for potential inclusion in a Red Hat Enterprise Linux Update release for currently deployed products. This request is not yet committed for inclusion in an Update release.
Patch in comment #1 compiles clean, boots clean. I think this patch is the way to go -- we shouldn't remove the duplicate definition of COMMAND_LINE_SIZE in param.h because we might break customer's out-of-tree drivers. P.
Prarit, Yep, based on earlier conversation, agreed (also ACK'ed by me now). To follow up about upstream, with the x86 merge, they have indeed removed the duplicate definition of COMMAND_LINE_SIZE; it is now just defined in include/asm-x86/setup.h. Chris Lalancette
in 2.6.18-68.el5 You can download this test kernel from http://people.redhat.com/dzickus/el5
An advisory has been issued which should help the problem described in this bug report. This report is therefore being closed with a resolution of ERRATA. For more information on the solution and/or where to find the updated files, please follow the link below. You may reopen this bug report if the solution does not work for you. http://rhn.redhat.com/errata/RHBA-2008-0314.html