Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.
For bugs related to Red Hat Enterprise Linux 5 product line. The current stable release is 5.10. For Red Hat Enterprise Linux 6 and above, please visit Red Hat JIRA https://issues.redhat.com/secure/CreateIssue!default.jspa?pid=12332745 to report new issues.

Bug 427423

Summary: [RHEL 5.2]: Build warning on i686 with -62 kernel
Product: Red Hat Enterprise Linux 5 Reporter: Chris Lalancette <clalance>
Component: kernelAssignee: Prarit Bhargava <prarit>
Status: CLOSED ERRATA QA Contact: Martin Jenner <mjenner>
Severity: low Docs Contact:
Priority: low    
Version: 5.2CC: dzickus
Target Milestone: rc   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: RHBA-2008-0314 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2008-05-21 15:05:36 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
Patch that should resolve this issue (untested) none

Description Chris Lalancette 2008-01-03 18:42:09 UTC
Description of problem:
When building the -62 kernel with the kernel-2.6.18-i686.config, I see the
following build warning a few different times:


In file included from init/main.c:57:
include/asm/setup.h:20:1: warning: "COMMAND_LINE_SIZE" redefined
In file included from include/linux/sched.h:42,
                 from include/linux/module.h:9,
                 from init/main.c:15:
include/asm/param.h:21:1: warning: this is the location of the previous definition

Looking at it with Don, this seems to be new between -58 and -62; I haven't
tracked it down further than that.

Comment 1 Prarit Bhargava 2008-01-03 19:04:39 UTC
Created attachment 290758 [details]
Patch that should resolve this issue (untested)

Comment 2 RHEL Program Management 2008-01-03 19:25:52 UTC
This request was evaluated by Red Hat Product Management for inclusion in a Red
Hat Enterprise Linux maintenance release.  Product Management has requested
further review of this request by Red Hat Engineering, for potential
inclusion in a Red Hat Enterprise Linux Update release for currently deployed
products.  This request is not yet committed for inclusion in an Update
release.

Comment 3 Prarit Bhargava 2008-01-03 22:19:00 UTC
Patch in comment #1 compiles clean, boots clean.  I think this patch is the way
to go -- we shouldn't remove the duplicate definition of COMMAND_LINE_SIZE in
param.h because we might break customer's out-of-tree drivers.

P.

Comment 4 Chris Lalancette 2008-01-03 22:38:50 UTC
Prarit,
     Yep, based on earlier conversation, agreed (also ACK'ed by me now).  To
follow up about upstream, with the x86 merge, they have indeed removed the
duplicate definition of COMMAND_LINE_SIZE; it is now just defined in
include/asm-x86/setup.h.

Chris Lalancette

Comment 5 Don Zickus 2008-01-14 20:05:23 UTC
in 2.6.18-68.el5
You can download this test kernel from http://people.redhat.com/dzickus/el5

Comment 8 errata-xmlrpc 2008-05-21 15:05:36 UTC
An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on the solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHBA-2008-0314.html