Spec URL: http://terjeros.fedorapeople.org/cpipe/cpipe.spec SRPM URL: http://terjeros.fedorapeople.org/cpipe/cpipe-3.0.1-1.fc8.src.rpm Description: Cpipe copies its standard input to its standard output while measuring the time it takes to read an input buffer and write an output buffer. Statistics of average throughput and the total amount of bytes copied are printed to the standard error output.
Why you are using group Development/Tools ? It has nothing with development. I think better group is defined upstream: Applications/Archiving, or may be Applications/System. %{__chmod} 0644 %{buildroot}%{_mandir}/man1/%{name}* - it is not necessary, just add %attr(0644, root, root) before this file in %files section. Some developers does not like macros like "%{__rm}" or "%{__make}".
Why cpipe is better like program "pv" already included in Fedora? Do we need both of them?
If the contributor is willing to package cpipe it is fine. It is still useful to point that it is redundant with another package since the contributor may change his mind then.
> Why you are using group Development/Tools ? It has nothing with development. > I think better group is defined upstream: Applications/Archiving, or may be > Applications/System. I don't know, Applications/Archiving was too strange andnarrow, Applications/System is possible. > %{__chmod} 0644 %{buildroot}%{_mandir}/man1/%{name}* > - it is not necessary, just add %attr(0644, root, root) before this file in > %files section. I like it this way, as it clearly signal that something is wrong. > Some developers does not like macros like "%{__rm}" or "%{__make}". I prefer to use macros in my packages. > Why cpipe is better like program "pv" already included in Fedora? > Do we need both of them? I see no harm in including cpipe.
No problem - License matches, good to Fedora - Source tarball matches - Spec file good - Builds (at least on dist-f9: http://koji.fedoraproject.org/koji/taskinfo?taskID=365669 ) build.log no problem - Can be installed - Seems to work ---------------------------------------------------------------------------- This package (cpipe) is APPROVED by me ----------------------------------------------------------------------------
A few comments: (In reply to comment #1) > %{__chmod} 0644 %{buildroot}%{_mandir}/man1/%{name}* > - it is not necessary, just add %attr(0644, root, root) before this file in > %files section. My opinition is always that setting modes/permissions by %attr should be avoided unless needed (such as using non-usual users, or setting setuid). Especially, changing permission by %attr often bears unwilling results for debuginfo rpms (using %attr(0755,root,root) but not changing permission correctly by the time %install ends makes binaries not stripped)
> This package (cpipe) is APPROVED by me Thanks! New Package CVS Request ======================= Package Name: cpipe Short Description: Counting pipe Owners: terjeros Branches: F-7 F-8 InitialCC: Cvsextras Commits: yes
cvs done.
Please close this bug as NEXTRELEASE when rebuild on koji and push request on bodhi system are done.
Pushed for testing in F-7 and F-8.