Spec URL: http://www.wantstofly.org/~buytenh/fedora-packages/dropbear.spec SRPM URL: http://www.wantstofly.org/~buytenh/fedora-packages/dropbear-0.50-1.src.rpm Description: Dropbear is a relatively small SSH 2 server and client. Dropbear is particularly useful for "embedded"-type Linux (or other Unix) systems, such as wireless routers. This is my first package. I am looking for a sponsor.
Taking this one.
Only problems that I see: - Please put the full URL path to the Sources (where possible). - dropbear.src: W: strange-permission dropbear.init 0755 Should be easy enough to fix, just make sure the perms are -x on that file before making the SRPM. - dropbear.x86_64: W: file-not-utf8 /usr/share/doc/dropbear-0.50/CHANGES Just add these lines in %setup: # convert to UTF-8 iconv -f iso-8859-1 -t utf-8 -o CHANGES{.utf8,} mv CHANGES{.utf8,} - dropbear.x86_64: W: service-default-enabled /etc/rc.d/init.d/dropbear dropbear.x86_64: W: no-reload-entry /etc/rc.d/init.d/dropbear Do you intend for this service to be enabled by default? Also, since the init file is custom, please add the reload function. It can be as simple as calling "stop, start".
Thank you for the review. I have uploaded 0.50-2 (which incorporates all your review comments) to: http://www.wantstofly.org/~buytenh/fedora-packages/dropbear-0.50-2.src.rpm I hope I've fixed everything in this version.
Good: - rpmlint checks return: dropbear.src:81: W: macro-in-%changelog setup dropbear.src: W: mixed-use-of-spaces-and-tabs (spaces: line 82, tab: line 1) Both of these are trivial, but you really shouldn't use macros in %changelog, because rpm will try to evaluate them. Safe to ignore. - package meets naming guidelines - package meets packaging guidelines - license (MIT) OK, text in %doc, matches source - spec file legible, in am. english - source matches upstream (97f31bbe1d36f156ec895de97ecc1d400da5f0e5) - package compiles on devel (x86_64) - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - %clean ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - no need for .desktop file APPROVED. Go ahead and request sponsorship, as described here: http://fedoraproject.org/wiki/PackageMaintainers/Join#head-a601c13b0950a89568deafa65f505b4b58ee869b
New Package CVS Request ======================= Package Name: dropbear Short Description: SSH2 server and client Owners: buytenh Branches: F-8 InitialCC: Cvsextras Commits: yes
cvs done.
I would like to see this in EPEL. Lennert: I'd be happy if you could maintain it; would you?
Package Change Request ====================== Package Name: dropbear New Branches: EL-4 EL-5
Package Change Request ====================== Package Name: dropbear New Branches: epel7 Owners: buytenh cicku itamarjp
Git done (by process-git-requests).