Bug 427787 - Please add -Wl,--as-needed to the standard CFLAGS
Please add -Wl,--as-needed to the standard CFLAGS
Product: Fedora
Classification: Fedora
Component: redhat-rpm-config (Show other bugs)
All Linux
low Severity low
: ---
: ---
Assigned To: Jon Masters
Fedora Extras Quality Assurance
Depends On:
  Show dependency treegraph
Reported: 2008-01-07 11:07 EST by Arjan van de Ven
Modified: 2009-07-14 14:00 EDT (History)
4 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Last Closed: 2009-07-14 14:00:12 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---

Attachments (Terms of Use)

  None (edit)
Description Arjan van de Ven 2008-01-07 11:07:44 EST
Description of problem:

-Wl,--as-needed has the effect of telling the linker to not make a binary pull 
in libraries it doesn't use/need. This is actually a common thing in the world 
of pkg-config sadly. The effect of pulling such spurious libraries in is that 
programs use more memory and take longer to start up.

The theoretical downside would be (and this is why it isn't default in ld) 
that a program could have plugins, where the program links to a library with 
the sole purpose of providing it to plugins, while the plugins aren't linked 
to the library. IMO that's broken and in practice this doesn't actually happen 
(in practice the plugins will link to the library they depend on)
Comment 1 Panu Matilainen 2008-01-08 03:06:40 EST
Jakub, thoughts / comments?
Comment 2 Jakub Jelinek 2008-01-08 03:13:42 EST
--as-needed is a positional switch, which doesn't nest, so the next
--no-as-needed which e.g. gcc inserts after -lgcc_s cancels it anyway.  Setting
this in rpm is IMHO a bad idea, it should be done in pkg-config/libtool, enable
it before libraries which aren't necessarily needed and turn it again off after
that list.
Comment 3 Arjan van de Ven 2008-01-10 23:00:06 EST
Despite what you say, adding it to the CFLAGS does have a positive effect; the 
autoconf/automake packages don't depend on the implicit CFLAGS pickup (which 
would be before -lgcc_s), but add their own explicit CFLAGS on the gcc command 
line so it's still in effect.

While I don't disagree with your "it should be done in pkg-config".. that's 
something that was true 3 years ago as well.. but unlikely to change.
Adding it to fedora cflags does have a positive effect... do you see any 
negative effects?
Comment 4 Jon Masters 2008-04-25 21:45:40 EDT
Anyone got any objections to just adding this?
Comment 5 Bug Zapper 2008-05-14 00:19:26 EDT
Changing version to '9' as part of upcoming Fedora 9 GA.
More information and reason for this action is here:
Comment 6 Bug Zapper 2009-06-09 19:21:01 EDT
This message is a reminder that Fedora 9 is nearing its end of life.
Approximately 30 (thirty) days from now Fedora will stop maintaining
and issuing updates for Fedora 9.  It is Fedora's policy to close all
bug reports from releases that are no longer maintained.  At that time
this bug will be closed as WONTFIX if it remains open with a Fedora 
'version' of '9'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version prior to Fedora 9's end of life.

Bug Reporter: Thank you for reporting this issue and we are sorry that 
we may not be able to fix it before Fedora 9 is end of life.  If you 
would still like to see this bug fixed and are able to reproduce it 
against a later version of Fedora please change the 'version' of this 
bug to the applicable version.  If you are unable to change the version, 
please add a comment here and someone will do it for you.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events.  Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

The process we are following is described here: 
Comment 7 Bug Zapper 2009-07-14 14:00:12 EDT
Fedora 9 changed to end-of-life (EOL) status on 2009-07-10. Fedora 9 is 
no longer maintained, which means that it will not receive any further 
security or bug fix updates. As a result we are closing this bug.

If you can reproduce this bug against a currently maintained version of 
Fedora please feel free to reopen this bug against that version.

Thank you for reporting this bug and we are sorry it could not be fixed.

Note You need to log in before you can comment on or make changes to this bug.