Spec URL: http://huzaifas.fedorapeople.org/spec/powertop.spec SRPM URL: http://huzaifas.fedorapeople.org/srpms/powertop-1.9-0.fc8.src.rpm Description: Computer programs can make your computer use more power. PowerTOP is a Linux tool that helps you find those programs that are misbehaving while your computer is idle.
Suggestions 1) change Source URL look like to http://www.lesswatts.org/projects/powertop/download/%{name}-%{version}.tar.gz 2) rpmlint gave me powertop.i386: E: description-line-too-long PowerTOP is a Linux tool that helps you find those programs that are misbehaving while your computer is idle. ==> Your description lines must not exceed 79 characters. If a line is exceeding this number, cut it to fit in two lines. 3) you don't need find $RPM_BUILD_ROOT -name '*.la' -exec rm -f {} ';'
All the changes have been mode as required. Spec URL: http://huzaifas.fedorapeople.org/spec/powertop.spec SRPM URL: http://huzaifas.fedorapeople.org/srpms/powertop-1.9-0.fc8.src.rpm
Make the habit of increasing release tag for each newly posted SRPM otherwise it may confuse reviewer. Review: + package builds in mock (rawhide i386). + rpmlint is silent for SRPM and for RPM. + source files match upstream. 7e2cd799941350a45586edac43760ac9 powertop-1.9.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc files present. + BuildRequires are proper. + Compiler flags used correctly. + defattr usage is correct + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code. + no static libraries. + no .pc file present. + no -devel subpackage exists. + no .la files. + translations are available. + Does owns the directories it creates. + no duplicates in %files. + file permissions are appropriate. + no scriptlets are used. + Not a GUI app. APPROVED.
Why is powertop being reviewed? powertop is already in Fedora http://koji.fedoraproject.org/koji/packageinfo?packageID=4369
damn! How come I miss this to check? Thanks for replying here before cvs request placed.
Sorry for the trouble, i seem to have missed it to.
I am glad to help. :-)
Thanks for that. I wish someone please write a script and/or add it to commit button on new package process submission that will check newly introducing package name on koji build server and in existing bugzilla review requests.