This service will be undergoing maintenance at 00:00 UTC, 2016-09-28. It is expected to last about 1 hours
Bug 428103 - Review Request: powertop - tool that helps you find misbehaving programs while your computer is idle.
Review Request: powertop - tool that helps you find misbehaving programs whil...
Status: CLOSED NOTABUG
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Parag AN(पराग)
Fedora Extras Quality Assurance
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2008-01-09 03:31 EST by Huzaifa S. Sidhpurwala
Modified: 2008-01-09 05:50 EST (History)
2 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2008-01-09 04:27:52 EST
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:


Attachments (Terms of Use)

  None (edit)
Description Huzaifa S. Sidhpurwala 2008-01-09 03:31:24 EST
Spec URL: http://huzaifas.fedorapeople.org/spec/powertop.spec
SRPM URL: http://huzaifas.fedorapeople.org/srpms/powertop-1.9-0.fc8.src.rpm
Description: 

Computer programs can make your computer use more power.
PowerTOP is a Linux tool that helps you find those programs that are misbehaving while your computer is idle.
Comment 1 Parag AN(पराग) 2008-01-09 03:41:54 EST
Suggestions
1) change Source URL look like to
 http://www.lesswatts.org/projects/powertop/download/%{name}-%{version}.tar.gz
 
2) rpmlint gave me
 powertop.i386: E: description-line-too-long PowerTOP is a Linux tool that helps
you find those programs that are misbehaving while your computer is idle.
 ==> Your description lines must not exceed 79 characters. If a line is exceeding
this number, cut it to fit in two lines.

3) you don't need
  find $RPM_BUILD_ROOT -name '*.la' -exec rm -f {} ';'


Comment 2 Huzaifa S. Sidhpurwala 2008-01-09 03:49:24 EST
All the changes have been mode as required.

Spec URL: http://huzaifas.fedorapeople.org/spec/powertop.spec
SRPM URL: http://huzaifas.fedorapeople.org/srpms/powertop-1.9-0.fc8.src.rpm
Comment 3 Parag AN(पराग) 2008-01-09 04:01:51 EST
Make the habit of increasing release tag for each newly posted SRPM otherwise it
may confuse reviewer.

Review:
+ package builds in mock (rawhide i386).
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream.
7e2cd799941350a45586edac43760ac9  powertop-1.9.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc files present.
+ BuildRequires are proper.
+ Compiler flags used correctly.
+ defattr usage is correct
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code.
+ no static libraries.
+ no .pc file present.
+ no -devel subpackage exists.
+ no .la files.
+ translations are available.
+ Does owns the directories it creates.
+ no duplicates in %files.
+ file permissions are appropriate.
+ no scriptlets are used.
+ Not a GUI app.

APPROVED.
Comment 4 José Matos 2008-01-09 04:21:31 EST
Why is powertop being reviewed?

powertop is already in Fedora
http://koji.fedoraproject.org/koji/packageinfo?packageID=4369
Comment 5 Parag AN(पराग) 2008-01-09 04:27:52 EST
damn! How come I miss this to check?
Thanks for replying here before cvs request placed.
Comment 6 Huzaifa S. Sidhpurwala 2008-01-09 04:30:46 EST
Sorry for the trouble, i seem to have missed it to.
Comment 7 José Matos 2008-01-09 05:03:52 EST
I am glad to help. :-)
Comment 8 Parag AN(पराग) 2008-01-09 05:50:39 EST
Thanks for that. I wish someone please write a script and/or add it to commit
button on new package process submission that will check newly introducing
package name on koji build server and in existing bugzilla review requests.


Note You need to log in before you can comment on or make changes to this bug.