Bug 428114 - Review Request: perl-User - API for locating user information regardless of OS
Review Request: perl-User - API for locating user information regardless of OS
Status: CLOSED NEXTRELEASE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Parag AN(पराग)
Fedora Extras Quality Assurance
:
Depends On:
Blocks: 428115
  Show dependency treegraph
 
Reported: 2008-01-09 05:52 EST by Xavier Bachelot
Modified: 2008-01-09 16:13 EST (History)
2 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2008-01-09 16:13:02 EST
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
panemade: fedora‑review+
kevin: fedora‑cvs+


Attachments (Terms of Use)

  None (edit)
Description Xavier Bachelot 2008-01-09 05:52:07 EST
Spec URL: http://washington.kelkoo.net/fedora/SPECS/perl-User.spec
SRPM URL: http://washington.kelkoo.net/fedora/SRPMS/perl-User-1.8-1.fc8.src.rpm
Description: This module allows applications to retrieve per-user characteristics.
Comment 1 Parag AN(पराग) 2008-01-09 06:56:48 EST
I don't think you need 
%check ||:
make it 
%check only.


Review:
+ package builds in mock (development i386).
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
b8b2c677dc4ef08e84b5b4f8cb021540  User-1.8.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test gave
PERL_DL_NONLAZY=1 /usr/bin/perl "-Iblib/lib" "-Iblib/arch" test.pl
1..3
# Running under perl version 5.008008 for linux
# Current time local: Wed Jan  9 06:21:40 2008
# Current time GMT:   Wed Jan  9 11:21:40 2008
# Using Test.pm version 1.25
ok 1
ok 2
ok 3
+ Package perl-User-1.8-1.fc9 ->
  Provides: perl(User) = 1.8
  Requires: perl(:MODULE_COMPAT_5.8.8) perl(Exporter) perl(strict) perl(vars)
APPROVED.

Comment 2 Xavier Bachelot 2008-01-09 08:38:05 EST
Thx Parag.

%make check fixed in :
http://washington.kelkoo.net/fedora/SPECS/perl-User.spec
http://washington.kelkoo.net/fedora/SRPMS/perl-User-1.8-2.fc8.src.rpm

New Package CVS Request
=======================
Package Name: perl-User
Short Description: API for locating user information regardless of OS
Owners: xavierb
Branches: F-8
InitialCC: 
Cvsextras Commits: yes
Comment 3 Kevin Fenzi 2008-01-09 13:25:07 EST
cvs done.
Comment 4 Xavier Bachelot 2008-01-09 16:13:02 EST
Thanks Kevin.

Imported and built for devel and F-8.

Note You need to log in before you can comment on or make changes to this bug.