Red Hat Bugzilla – Bug 428250
Review Request: gpicview - A simple fast image viewer
Last modified: 2008-12-01 17:03:35 EST
Spec URL: http://mwiriadi.fedorapeople.org/packages/gpicview/gpicview.spec SRPM URL: http://mwiriadi.fedorapeople.org/packages/gpicview/gpicview-0.1.7-1.fc8.src.rpm Description: Gpicview is an image viewer that is: Extremely lightweight and fast with low memory usage Very suitable for default image viewer of desktop system Simple and intuitive interface Minimal lib dependency: Only pure GTK+ is used Desktop independent: Doesn't require any specific desktop environment RPM Lint: On RPM file [marc@Strike-Lap i386]$ rpmlint gpicview-0.1.7-1.fc8.i386.rpm gpicview.i386: E: zero-length /usr/share/doc/gpicview-0.1.7/README gpicview.i386: E: zero-length /usr/share/doc/gpicview-0.1.7/NEWS gpicview.i386: E: zero-length /usr/share/doc/gpicview-0.1.7/TODO gpicview.i386: E: zero-length /usr/share/doc/gpicview-0.1.7/ChangeLog gpicview.i386: W: file-not-in-%lang /usr/share/locale/cs/LC_MESSAGES/gpicview.mo gpicview.i386: W: file-not-in-%lang /usr/share/locale/de_DE/LC_MESSAGES/gpicview.mo gpicview.i386: W: file-not-in-%lang /usr/share/locale/es/LC_MESSAGES/gpicview.mo gpicview.i386: W: file-not-in-%lang /usr/share/locale/gl/LC_MESSAGES/gpicview.mo gpicview.i386: W: file-not-in-%lang /usr/share/locale/pt_BR/LC_MESSAGES/gpicview.mo gpicview.i386: W: file-not-in-%lang /usr/share/locale/sk/LC_MESSAGES/gpicview.mo gpicview.i386: W: file-not-in-%lang /usr/share/locale/zh_TW/LC_MESSAGES/gpicview.mo On SRPM: Nothing Only issue I have thats severe is the *.mo files and I'm not to sure how to fix it. I can compile it in F-8 yet mock building it in devel doesn't build claiming that the *mo files do not exist.
1) You are not using http://fedoraproject.org/wiki/Packaging/Guidelines#head-8c605ebf8330f6d505f384e671986fa99a8f72ee 2) remove .mo from %files 3) add gettext as BR 4) you don't need pkgconfig as BR 5) remove empty files README NEWS TODO Changelog
Fixed. http://mwiriadi.fedorapeople.org/packages/gpicview/gpicview.spec http://mwiriadi.fedorapeople.org/packages/gpicview/gpicview-0.1.7-2.fc8.src.rpm Thanks for the link I had read it but missed that part I've bookmarked it now.
Created attachment 291354 [details] Some Cleanups to SPEC I did some changes to description, desktop-file-install command. Use this SPEC and provide new update for review.
Done http://mwiriadi.fedorapeople.org/packages/gpicview/gpicview.spec http://mwiriadi.fedorapeople.org/packages/gpicview/gpicview-0.1.7-3.fc8.src.rpm
Review: + package builds in mock (development i386). + rpmlint is silent for SRPM and for RPM. + source files match upstream url a1e70f726dbdb4c2aa456a50a3f535fd gpicview-0.1.7.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no static libraries. + no -devel subpackage + no .la files. + translations are available + Does owns the directories it creates. + no scriptlets present. + desktop file installed correctly. + no duplicates in %files. + file permissions are appropriate. + Desktop file handled correctly. + GUI app. APPROVED.
======================= Package Name: gpicview Short Description: A simple fast image viewer Owners: mwiriad Branches: F-7 F-8 devel InitialCC: mwiriad Cvsextras Commits: yes
cvs done. (with corrected owner account name)
Package Change Request ====================== Package Name: gpicview New Branches: EL-5 Owners: pertusus Marc agreed by mail that I could be the EL-5 maintainer. He should be able to confirm here.
I have agreed for Patrice to be the EL-5 maintainer I'm in the process of adding him in pkgdb
cvs done. (you likely need the EL-5 branch before pkgdb will show it to add him. ;)