Spec URL: http://allisson.fedorapeople.org/packages/amora/amora.spec SRPM URL: http://allisson.fedorapeople.org/packages/amora/amora-0.9-1.fc8.src.rpm Description: Amora is an application that enables you to control your PC desktop using a cellphone. It uses bluetooth to send mouse and keyboard events to the graphical session. With it you can control your slides in OpenOffice.org, movies or any other application. Amora also has a screenshot feature, where you can see a thumbnail in the cellphone screen of the currently focused window in your desktop.
License should be GPLv2+ you don't need BR: pkgconfig
Update package: Spec URL: http://allisson.fedorapeople.org/packages/amora/amora.spec SRPM URL: http://allisson.fedorapeople.org/packages/amora/amora-1.0-1.fc8.src.rpm Changes: Update to 1.0
Review: + package builds in mock (rawhide i386). + rpmlint is silent for SRPM and RPM. + source files match upstream. 39738c99dba04f8f75069d0539a3141b amora-server-1.0svn.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc files present. + BuildRequires are proper. + Compiler flags are honoured correctly. + defattr usage is correct. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code. + no static libraries. + no .pc file present. + no -devel subpackage exists. + no .la files. + no translations are available. + Does owns the directories it creates. + no duplicates in %files. + file permissions are appropriate. + no scriptlets are used. + Not a GUI app. APPROVED.
New Package CVS Request ======================= Package Name: amora Short Description: a mobile remote assistant Owners: allisson Branches: F-7 F-8 Cvsextras Commits: yes
cvs done.
All done, thanks for review. http://koji.fedoraproject.org/koji/buildinfo?buildID=31899 http://koji.fedoraproject.org/koji/buildinfo?buildID=31897 http://koji.fedoraproject.org/koji/buildinfo?buildID=31898