Description of problem: Version-Release number of selected component (if applicable): How reproducible: Steps to Reproduce: 1. 2. 3. Actual results: Expected results: Additional info:
Created attachment 291703 [details] The patch for Areca driver, arcmsr, against RHEL4.7
This request was evaluated by Red Hat Product Management for inclusion in a Red Hat Enterprise Linux maintenance release. Product Management has requested further review of this request by Red Hat Engineering, for potential inclusion in a Red Hat Enterprise Linux Update release for currently deployed products. This request is not yet committed for inclusion in an Update release.
Nick, you patchfiles are probably generated against RHEL5.1, they are failing in this case. I'm going to send to you the sources from 4.6. Please recreate/backport the pathset. RHEL4 is based on kernel 2.6.9.
Nick, you could also use the sources from bz#233399 https://bugzilla.redhat.com/show_bug.cgi?id=233399 Thanks for your time
Created attachment 294727 [details] Update the patch for arcmsr
Created attachment 294728 [details] Update the patch for arcmsr
Nick, again this patch fails to apply against current RHEL4.6 code base. For example this doesn't work because there function arcmsr_adjust_disk_queue_depth is not part of arcmsr_hba.c. -static int arcmsr_adjust_disk_queue_depth(struct scsi_device *sdev, int queue_depth) +static ssize_t arcmsr_adjust_disk_queue_depth(struct device *dev, const char *buf, size_t count) Or I'm doing something wrong ? Try to use code base from https://bugzilla.redhat.com/show_bug.cgi?id=233399 From Comment 29 in233399 http://people.redhat.com/~jbaron/rhel4/
OK, I will check.
Tomas, Would you please check if the arcmsr source code version is 1.20.00.13? If it is, arcmsr_adjust_disk_queue_depth() should be there. The kernel is 2.6.9-67.ELsmp of RHEL4.6 GA on my site. Is it synchronous to yours? Thanks,
Created attachment 295784 [details] arcmsr_hba.c Nick, sorry for being late, I was on vacation last week. It is "Driver Version 1.20.00.13", but the symbol arcmsr_adjust_disk_queue_depth is not there as you can see in the attachment.
Nick, do you need some other help from me ?
Hi Tomas, I check the patch that I made for RHEL4.6 and found it really lacks arcmsr_adjust_disk_queue_depth(). It just came to my mind that I made a few changes on arcmsr-1.20.00.13 to fit RHEL4.6 But I don't keep the variant of source code that I ported for RHEL4.6. I should be blamed. Sorry to bother you. Would you please kindly send me the (1)arcmsr_hba.c, (2)arcmsr_attr.c, (3)arcmsr.h, (4)pci_ids.h, (5)ChangeLog.arcmsr and (6)Kconfig in /usr/src/linux/drivers/scsi?
Created attachment 296175 [details] areca files Nick, I attached the files here, note that there is not Changelog.arcmsr in the current codebase. Other way how to get the sources is mentioned in Comments #7,#10.
Created attachment 296695 [details] The patch for arcmsr-1.20.00.15.RH4U7-80227 This is the patch for arcmsr-1.20.00.15.RH4U7 @ RHEL4 Update 7
Nick, it looks like, that in the Kconfig part of your patch, you are changing things that do not belong to the arcmsr driver. Please could you clarify this ?
Created attachment 296981 [details] patch for Kconfig Tomas, Would you please check if this answers your need? If not, please let me know. Thanks,
Nick, thanks it looks good. +** For history of changes, see Documentation/scsi/ChangeLog.arcmsr +** Firmware Specification, see Documentation/scsi/arcmsr_spec.txt The patches for these files are missing, it looks like you are moving the firmware spec from arcmsr.h to arcmsr_spec.txt, so could you provide a patch for that(also for ChangeLog.arcmsr) ? This - arcmsr_interrupt(acb); + arcmsr_interrupt(acb);/* FIXME: need spinlock */ what does this change mean, shouldn't it rather be fixed ?
Nick, you are removing in the function void arcmsr_polling_ccbdone the line : - poll_ccb_done = 1; The upstream version does not remove this, so it is only a lapse or is there a reason for it ?
Hi Tomas, For the comment #20, just for sure, do you really need the ChangeLog.arcmsr? You mentioned there is no ChangeLog.arcmsr for the code base in Comment#16. If you really need it, I will make a patch for you. As for -arcmsr_interrupt(acb); +arcmsr_interrupt(acb);/* FIXME: need spinlock */ this is from kernel.org comment, it is for the notification purpose. It is still an open issue, although I think it has no need to do a fix. But just let it be there, maybe someone could have other special comments. For the comment #21, I check it on my site and find it has been removed the line, poll_ccb_done = 1. It could be staying in -mm stage.
Hi Nick, I created the arcmsr_spec.txt from upstream and I agree with you that the Changelog is not so important. Last open issue which I don't understand yet is the "poll_ccb_done = 1". Should the line stay in the sources or not? I think we will better use the upstream version - what do you think ?
After my last review, I found it will be logical if there is no "poll_ccb_done = 1". I have upstreamed to kernel.org with a version w/o poll_ccb_done = 1. I agree with you'r idea. But I think it will be adopted into kernel source sooner or later. If you persist in your opinion, I will submit to it. BTW, should I make a patch for arcmsr_spec.txt? Thanks,
Nick, thanks, the patch for arcmsr_spec.txt is not needed as I created it myself. >I have upstreamed to kernel.org with a version w/o poll_ccb_done = 1. Could you point me where you upstreamed it ? I mean on which list + date.
Created attachment 297765 [details] new version Nick, this is the version we were talking about. Please check it if it is OK.
Committed in 68.27.EL . RPMS are available at http://people.redhat.com/vgoyal/rhel4/
Hi Tomas, Sorry, I paid no attention to this message. Do you still waiting my response?
Nick, don't know what message, but now is important the message from Comment #28, please download and test the new kernel.
Tomas, I can't boot the kernel.
Nick, I'm going to test it, but could you more precisely say what kernel you couldn't boot and if any, some error messages ? Btw. this a kernel for RHEL4.7.
I download kernel-2.6.9-70.EL.src.rpm and kernel-2.6.9-70.EL.x86_64.rpm and build the kernel. But after I reboot the built kernel, I got kernel panic. It has nothing to do with Areca driver because I don't have Areca RAID card on it.
The kernel-2.6.9-70.EL.x86_64.rpm is already a package with a built kernel. I've just tried to install it with rpm ('rpm -ivh kernel-2.6.9-70.EL.i686.rpm') and it works. Does it work when you install it directly without compiling ?
this bug has been tagged for inclusion in RHEL4.7 release notes. please provide a short summary of changes applied in this update to the arcmsr driver. thanks!
Don, What kind of update to arcmsr? I have no idea what are you talking about.
Nick, 'release notes' is a text which describes what is new in RHEL4.7. So we should write down what is new in this driver - for example - driver updated to version to 1.20.00.15.RH. This update applies several changes, most notably: * Support for new controllers - ARC1200/1201/1202 SATA RAID adapter * Many bugfixes and minor improvements If you are aware of something more precise then 'Many bugfixes and minor improvements' then please advise.
Thanks Tomas. adding to RHEl4.7 release notes under "Driver Updates => Storage": <quote> arcmsr: driver updated to version 1.20.00.15.rh. This update applies several bug fixes and minor enhancements; in addition, it also provides support for the following SATA RAID adapters: * ARC1200 * ARC1201 * ARC1202 </quote> please advise if any further revisions are required. thanks!
Would you please check the arcmsr version in arcmsr.h by searching ARCMSR_DRIVER_VERSION macro? Thank you,
Nick, sorry I haven't noticed your question(Comment #40). The version from the latest attachment is +#define ARCMSR_DRIVER_VERSION "Driver Version 1.20.00.15.RH4U7 2008/02/27"
Hi Tomas, Sorry to late response. If the driver in RHEL4U7 is "Driver Version 1.20.00.15.RH4U7 2008/02/27", it is not the first version that includes the ARC120X HBAs. I am afraid you get wrong or I misconstrue you. Would you mind to kindly check it out? Thanks,
Nick, from the latest attachment +#define PCI_DEVICE_ID_ARECA_1200 0x1200 +#define PCI_DEVICE_ID_ARECA_1201 0x1201 +#define PCI_DEVICE_ID_ARECA_1202 0x1202 this looks like a support for a new hardware, please check it. Is there anything else what you think should be mentioned in the release notes ?
Hi, the RHEL4.7 release notes deadline is on June 17, 2008 (Tuesday). they will undergo a final proofread before being dropped to translation, at which point no further additions or revisions will be entertained. a mockup of the RHEL4.7 release notes can be viewed here: http://intranet.corp.redhat.com/ic/intranet/RHEL4u7relnotesmockup.html please use the aforementioned link to verify if your bugzilla is already in the release notes (if it needs to be). each item in the release notes contains a link to its original bug; as such, you can search through the release notes by bug number. Cheers, Don
Don, The hyperlink, http://intranet.corp.redhat.com/ic/intranet/RHEL4u7relnotesmockup.html, is not available.
Hi Nick, sorry, that page is only available internally to RHEL people. anyhow, the release note for this item is quoted in Comment#39
Created attachment 308180 [details] Change Log for arcmsr
~~~~~~~~~~~~~~ ~ Attention: ~ Feedback requested regarding this **High Priority** bug. ~~~~~~~~~~~~~~ A fix for this issue should be included in the latest packages contained in RHEL4.7-Snapshot1--available now on partners.redhat.com. After you (Red Hat Partner) have verified that this issue has been addressed, submit a comment describing the passing results of your test in appropriate detail, along with which snapshot and package version tested. The bugzilla will be updated by Red Hat Quality Engineering for you when this information has been received. If you believe this issue has not properly fixed or you are unable to verify the issue for any reason, please add a comment describing the most recent issues you are experiencing, along with which snapshot and package version tested. If you believe the bug has not been fixed, change the status of the bug to ASSIGNED. If you are receiving this message in Issue Tracker, please reply with a message to Issue Tracker about your results and bugzilla will be updated for you. If you need assistance accessing ftp://partners.redhat.com, please contact your Partner Manager. Thank you Red Hat QE Partner Management
Don, Could we close this bug report?
Nick, i believe that's up to QE. i only do the documentation for specific bugs. :-)
Nick, have you been able to successfully verify the bug in either the 4.7 Beta or Snapshot 1? If your latest findings indicate the bug has been addressed, QE will be glad to close this bug report for you.
Chris, Actually this is not a really bug. It starts to request adding Areca driver into RHEL4U7. Now, it seems so far so good. How do I close this bug? Thanks,
Nick, since there will be changes made to the kernel source to update the arcmsr driver, we must *verify* that these changes have been made correctly. Since you reported the request, it would be great if you could test and verify that this driver update has actually been properly included in the latest kernel available in the RHEL 4.7 Beta or Snapshot 1 and meets your expectations. Let me know which version of the kernel you tested. The latest RHEL4.7 snapshot is available on http://partners.redhat.com Additional information can be found in Comment #50. Thanks
Nick, this bugzilla must say open until the product GAs... since you've tested and verified the features update to the arcmsr driver, I'm going to change it to VERIFIED. No other action is needed from you at this point, unless anything is of issue to the submission.
Hi Andrius, I verified it on RHEL 4.7 Snapshot 1. So far so good.
Great, thanks for the update Nick!
An advisory has been issued which should help the problem described in this bug report. This report is therefore being closed with a resolution of ERRATA. For more information on therefore solution and/or where to find the updated files, please follow the link below. You may reopen this bug report if the solution does not work for you. http://rhn.redhat.com/errata/RHSA-2008-0665.html
Partners, I would like to thank you all for your participation in assuring the quality of this RHEL 4.7 Update Release. My hat's off to you all. Thanks.