+++ This bug was initially created as a clone of Bug #428963 +++ Add HDMI support for AMD ATI chipsets to allow HDMI to work on a wide variety of chipsets. The patch is for RS780, RV610, RV620, RV630, RV635, RV670, RV770. The patch has been tested on RV610, RV630 and with the patch it works correctly. The next stable/unstable release of also-sriver right after version 1.0.15 will include it, and the patch can already be found in the alsa-driver daily snapshot.
This request was evaluated by Red Hat Product Management for inclusion in a Red Hat Enterprise Linux maintenance release. Product Management has requested further review of this request by Red Hat Engineering, for potential inclusion in a Red Hat Enterprise Linux Update release for currently deployed products. This request is not yet committed for inclusion in an Update release.
Jaroslav, Does RHEL4 code base support HDMI audio support? I couldn't find the following files that we would have to modify to add the ATI HDMI support. sound/pci/hda/hda_intel.c sound/pci/hda/patch_atihdmi.c Are there any upstream links that we would have to backport? This is the patch that AMD would need in RHEL4.7. --- linux-2.6.18.x86_64/sound/pci/hda/patch_atihdmi.c.hdmiorig 2008-01-17 11:24:03.000000000 -0500 +++ linux-2.6.18.x86_64/sound/pci/hda/patch_atihdmi.c 2008-01-17 13:14:17.000000000 -0500 @@ -161,6 +161,7 @@ */ struct hda_codec_preset snd_hda_preset_atihdmi[] = { { .id = 0x1002793c, .name = "ATI RS600 HDMI", .patch = patch_atihdmi }, - { .id = 0x1002791a, .name = "ATI RS690 HDMI", .patch = patch_atihdmi }, - {} /* terminator */ + { .id = 0x1002791a, .name = "ATI RS690/780 HDMI", .patch = patch_atihdmi }, + { .id = 0x1002aa01, .name = "ATI R6xx HDMI", .patch = patch_atihdmi }, + {} /* terminator */ }; --- linux-2.6.18.x86_64/sound/pci/hda/hda_intel.c.hdmiorig 2008-01-17 11:23:52.000000000 -0500 +++ linux-2.6.18.x86_64/sound/pci/hda/hda_intel.c 2008-01-17 11:28:20.000000000 -0500 @@ -88,6 +88,14 @@ "{ATI, SB600}," "{ATI, RS600}," "{ATI, RS690}," + "{ATI, RS780}," + "{ATI, R600}," + "{ATI, RV630}," + "{ATI, RV610}," + "{ATI, RV670}," + "{ATI, RV635}," + "{ATI, RV620}," + "{ATI, RV770}," "{VIA, VT8251}," "{VIA, VT8237A}," "{SiS, SIS966}," @@ -1758,6 +1766,14 @@ { 0x1002, 0x4383, PCI_ANY_ID, PCI_ANY_ID, 0, 0, AZX_DRIVER_ATI }, /* ATI SB600 */ { 0x1002, 0x793b, PCI_ANY_ID, PCI_ANY_ID, 0, 0, AZX_DRIVER_ATIHDMI }, /* ATI RS600 HDMI */ { 0x1002, 0x7919, PCI_ANY_ID, PCI_ANY_ID, 0, 0, AZX_DRIVER_ATIHDMI }, /* ATI RS690 HDMI */ + { 0x1002, 0x960f, PCI_ANY_ID, PCI_ANY_ID, 0, 0, AZX_DRIVER_ATIHDMI }, /* ATI RS780 HDMI */ + { 0x1002, 0xaa00, PCI_ANY_ID, PCI_ANY_ID, 0, 0, AZX_DRIVER_ATIHDMI }, /* ATI R600 HDMI */ + { 0x1002, 0xaa08, PCI_ANY_ID, PCI_ANY_ID, 0, 0, AZX_DRIVER_ATIHDMI }, /* ATI RV630 HDMI */ + { 0x1002, 0xaa10, PCI_ANY_ID, PCI_ANY_ID, 0, 0, AZX_DRIVER_ATIHDMI }, /* ATI RV610 HDMI */ + { 0x1002, 0xaa18, PCI_ANY_ID, PCI_ANY_ID, 0, 0, AZX_DRIVER_ATIHDMI }, /* ATI RV670 HDMI */ + { 0x1002, 0xaa20, PCI_ANY_ID, PCI_ANY_ID, 0, 0, AZX_DRIVER_ATIHDMI }, /* ATI RV635 HDMI */ + { 0x1002, 0xaa28, PCI_ANY_ID, PCI_ANY_ID, 0, 0, AZX_DRIVER_ATIHDMI }, /* ATI RV620 HDMI */ + { 0x1002, 0xaa30, PCI_ANY_ID, PCI_ANY_ID, 0, 0, AZX_DRIVER_ATIHDMI }, /* ATI RV770 HDMI */ { 0x1106, 0x3288, PCI_ANY_ID, PCI_ANY_ID, 0, 0, AZX_DRIVER_VIA }, /* VIA VT8251/VT8237A */ { 0x1039, 0x7502, PCI_ANY_ID, PCI_ANY_ID, 0, 0, AZX_DRIVER_SIS }, /* SIS966 */ { 0x10b9, 0x5461, PCI_ANY_ID, PCI_ANY_ID, 0, 0, AZX_DRIVER_ULI }, /* ULI M5461 */ Bhavana
Brian, you mentione hda_intel and AZX in your codec update. See comment #3, does your 4.6 patch help us get that base support so that patch above can be submitted to 4.7?
Yes, it should.
OK, great, let me know once there is a source I can work off of for the HDMI audio patch.
Updated summary to clarify that this is an HDMI Audio issue.
Posted patch to RHML on Mar 17. RHEL RPM testing pending Brian's 20K ALSA patch being incorporated into RHEL4.7 code base.
Bhavana, Does it mean that RHEL4.7 will support HDMI once Brian's 20K ALSA patch has been incorporated? Can you notify us as soon as possible when Brian's patch is ready and new kernel rpm package is available too? Thanks
Committed in 70.EL. RPMS are available at http://people.redhat.com/vgoyal/
The device IDs have been added into sound/pci/azx/hda_intel.c of 2.6.9-70, but it seems that RHEL4 itself does not support HDMI audio well? Am I right? Is there any guy who can confirm the HDMI audio support of RHEL4.7? Thanks
Bhavana, Can you help to check with Red Hat whether RHEL4.7 itself support HDMI audio or not? Thanks
~~~~~~~~~~~~~~ ~ Attention: ~ Feedback requested regarding this **High Priority** bug. ~~~~~~~~~~~~~~ A fix for this issue should be included in the latest packages contained in RHEL4.7-Snapshot1--available now on partners.redhat.com. After you (Red Hat Partner) have verified that this issue has been addressed, submit a comment describing the passing results of your test in appropriate detail, along with which snapshot and package version tested. The bugzilla will be updated by Red Hat Quality Engineering for you when this information has been received. If you believe this issue has not properly fixed or you are unable to verify the issue for any reason, please add a comment describing the most recent issues you are experiencing, along with which snapshot and package version tested. If you believe the bug has not been fixed, change the status of the bug to ASSIGNED. If you are receiving this message in Issue Tracker, please reply with a message to Issue Tracker about your results and bugzilla will be updated for you. If you need assistance accessing ftp://partners.redhat.com, please contact your Partner Manager. Thank you Red Hat QE Partner Management
Created attachment 308764 [details] patch for ATI HDMI Device ID
I have updated a patch for Device ID. Please check.
Created attachment 308765 [details] The updated patch for HDMI Device ID
All mentioned PCI IDs are already in upstream. Ack from me.
AMD, the issues in this bug should have been addressed in the RHEL4U7 Beta or the latest snapshot 1, available at partners.redhat.com? Could you please verify this and report back your testing results here?
The testing results and the need for the patch reflects snapshot 1 testing results. RHEL4.7 code base is missing the patch in comment #19.
Submitted to RHML 6/10 and received 2 ACKs.
So, which kernel version is expected to include the patch in comment #19? Is it 2.6.9-73? Thanks
Committed in 73.EL . RPMS are available at http://people.redhat.com/vgoyal/rhel4/
Smoke test on 73.EL has been done. It has included the patch in comment #19. It works. Thanks.
The HDMI patch leads to USB EHCI failure on AMD SB700, which lead to very low performance to USB 2.0 devices such as external USB HDD. The interrupt 201 will be occupied by HDA, so ehci failed to request it. Here are the dmesg and /proc/interrupts.
Created attachment 312095 [details] dmesg in kernel 2.6.9-73 with EHCI failure
Created attachment 312096 [details] /proc/interrupts in kernel 2.6.9-72
Created attachment 312097 [details] /proc/interrupts in kernel 2.6.9-73
We found out the root cause: There is one bug when RedHat backported alsa driver to RHEL4.7, IRQF_SHARED in alsa-driver should NOT be replaced into 0x00000080 simply, instead, SA_SHIRQ should be used for old kernel versions like 2.6.9. Please re-check your alsa-driver backport. The patch below can fix the bug, which has been tested on SB700. Please add it to RHEL4.7 ASAP before its release, otherwise there will be many bugs besides the USB EHCI one reported above. Thanks.
Created attachment 312106 [details] Fix the IRQ request bug involved when RH backport alsa-driver
If RH still have some concern to add the fix patch above due to the coming RHEL4.7 release, please make sure the ATI HDMI device IDs must be withdrawn with the patch below to make USB EHCI work in RHEL4.7, and also update your release note if necessary that RHEL4.7 not supporting ATI HDMI audio. But this method is a workaround with little risk, not the solution. We strongly suggest RH can accept the IRQ bug fix above ASAP for RHEL 4.7. Thanks.
Created attachment 312108 [details] Removing the ATI HDMI IDs as a workaround, not encouraged
Is there any RH guy who are checking the bug in comment #33 and our fix?
AMD, the issues in Comment #33 are currently being reviewed. Thanks for the information. We'll report back with more as soon as possible.
AMD, it appears, due to the unexpected issues found during testing, that this bug will not be going into the RHEL4.7 update. Sorry for the bad news. Thanks again though for sending us your detailed testing results. We'll work on addressing this issue as soon as possible. Your patch is currently being reviewed. A request to include it in the next update release (4.8) has already been submitted.
Bug 456155 is to address the change needed to fix the feature in 4.8. Please see bug 456155 for more detailed info.
I created rpms with the patch found in comment #38 so it can be tested as soon as possible by all effected partners. Please find these rpms at http://people.redhat.com/jfeeney/.bz428964_454479 Note: the fix for bz454479 is also included in these rpms.
We did some USB and HDMI test with the above testing kernel (2.6.9-77.EL.jfeeney.454479.2): The USB EHCI bug has been fixed and HDMI still can work, We do not find any regression issue either so far, the test result of overnight USB stress test will come out tomorrow.
Shane, I am planning to do a big ALSA HDA driver update for RHEL 4.8. Could you test also kernels in bug#452846 (hdaUpdate3)? These kernels contains latest ALSA HDA driver code. Thank you.
Jaroslav, my comment has been added to the BZ #452846, please check it.
An advisory has been issued which should help the problem described in this bug report. This report is therefore being closed with a resolution of ERRATA. For more information on therefore solution and/or where to find the updated files, please follow the link below. You may reopen this bug report if the solution does not work for you. http://rhn.redhat.com/errata/RHSA-2008-0665.html
Partners, I would like to thank you all for your participation in assuring the quality of this RHEL 4.7 Update Release. My hat's off to you all. Thanks.